2022-08-31 14:25:22

by Xuezhi Zhang

Subject: [PATCH] scsi: megaraid: convert sysfs snprintf to sysfs_emit

From: Xuezhi Zhang <[email protected]>

Fix up all sysfs show entries to use sysfs_emit

Signed-off-by: Xuezhi Zhang <[email protected]>
---
drivers/scsi/megaraid/megaraid_mbox.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/megaraid/megaraid_mbox.c b/drivers/scsi/megaraid/megaraid_mbox.c
index 157c3bdb50be..132de68c14e9 100644
--- a/drivers/scsi/megaraid/megaraid_mbox.c
+++ b/drivers/scsi/megaraid/megaraid_mbox.c
@@ -3979,7 +3979,7 @@ megaraid_mbox_app_hndl_show(struct device *dev, struct device_attribute *attr, c

app_hndl = mraid_mm_adapter_app_handle(adapter->unique_id);

- return snprintf(buf, 8, "%u\n", app_hndl);
+ return sysfs_emit(buf, "%u\n", app_hndl);
}


@@ -4048,7 +4048,7 @@ megaraid_mbox_ld_show(struct device *dev, struct device_attribute *attr, char *b
}
}

- return snprintf(buf, 36, "%d %d %d %d\n", scsi_id, logical_drv,
+ return sysfs_emit(buf, "%d %d %d %d\n", scsi_id, logical_drv,
ldid_map, app_hndl);
}

--
2.25.1

2022-09-01 00:31:05

by Damien Le Moal

Subject: Re: [PATCH] scsi: megaraid: convert sysfs snprintf to sysfs_emit

On 8/31/22 23:03, Xuezhi Zhang wrote:
> From: Xuezhi Zhang <[email protected]>
>
> Fix up all sysfs show entries to use sysfs_emit
>
> Signed-off-by: Xuezhi Zhang <[email protected]>

Looks OK.

Reviewed-by: Damien Le Moal <[email protected]>

> ---
> drivers/scsi/megaraid/megaraid_mbox.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/megaraid/megaraid_mbox.c b/drivers/scsi/megaraid/megaraid_mbox.c
> index 157c3bdb50be..132de68c14e9 100644
> --- a/drivers/scsi/megaraid/megaraid_mbox.c
> +++ b/drivers/scsi/megaraid/megaraid_mbox.c
> @@ -3979,7 +3979,7 @@ megaraid_mbox_app_hndl_show(struct device *dev, struct device_attribute *attr, c
>
> app_hndl = mraid_mm_adapter_app_handle(adapter->unique_id);
>
> - return snprintf(buf, 8, "%u\n", app_hndl);
> + return sysfs_emit(buf, "%u\n", app_hndl);
> }
>
>
> @@ -4048,7 +4048,7 @@ megaraid_mbox_ld_show(struct device *dev, struct device_attribute *attr, char *b
> }
> }
>
> - return snprintf(buf, 36, "%d %d %d %d\n", scsi_id, logical_drv,
> + return sysfs_emit(buf, "%d %d %d %d\n", scsi_id, logical_drv,
> ldid_map, app_hndl);
> }
>

--
Damien Le Moal
Western Digital Research