2023-03-10 14:48:15

by Rob Herring (Arm)

Subject: [PATCH] clocksource: ti: Use of_property_read_bool() for boolean properties

It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties.
Convert reading boolean properties to to of_property_read_bool().

Signed-off-by: Rob Herring <[email protected]>
---
drivers/clocksource/timer-ti-dm-systimer.c | 4 ++--
drivers/clocksource/timer-ti-dm.c | 8 ++++----
2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/clocksource/timer-ti-dm-systimer.c b/drivers/clocksource/timer-ti-dm-systimer.c
index 632523c1232f..efa5f55a65f8 100644
--- a/drivers/clocksource/timer-ti-dm-systimer.c
+++ b/drivers/clocksource/timer-ti-dm-systimer.c
@@ -586,7 +586,7 @@ static int __init dmtimer_clkevt_init_common(struct dmtimer_clockevent *clkevt,
writel_relaxed(OMAP_TIMER_INT_OVERFLOW, t->base + t->wakeup);

pr_info("TI gptimer %s: %s%lu Hz at %pOF\n",
- name, of_find_property(np, "ti,timer-alwon", NULL) ?
+ name, of_property_read_bool(np, "ti,timer-alwon") ?
"always-on " : "", t->rate, np->parent);

return 0;
@@ -787,7 +787,7 @@ static int __init dmtimer_clocksource_init(struct device_node *np)
t->base + t->ctrl);

pr_info("TI gptimer clocksource: %s%pOF\n",
- of_find_property(np, "ti,timer-alwon", NULL) ?
+ of_property_read_bool(np, "ti,timer-alwon") ?
"always-on " : "", np->parent);

if (!dmtimer_sched_clock_counter) {
diff --git a/drivers/clocksource/timer-ti-dm.c b/drivers/clocksource/timer-ti-dm.c
index b24b903a8822..7031aa1bfdcb 100644
--- a/drivers/clocksource/timer-ti-dm.c
+++ b/drivers/clocksource/timer-ti-dm.c
@@ -1104,13 +1104,13 @@ static int omap_dm_timer_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, timer);

if (dev->of_node) {
- if (of_find_property(dev->of_node, "ti,timer-alwon", NULL))
+ if (of_property_read_bool(dev->of_node, "ti,timer-alwon"))
timer->capability |= OMAP_TIMER_ALWON;
- if (of_find_property(dev->of_node, "ti,timer-dsp", NULL))
+ if (of_property_read_bool(dev->of_node, "ti,timer-dsp"))
timer->capability |= OMAP_TIMER_HAS_DSP_IRQ;
- if (of_find_property(dev->of_node, "ti,timer-pwm", NULL))
+ if (of_property_read_bool(dev->of_node, "ti,timer-pwm"))
timer->capability |= OMAP_TIMER_HAS_PWM;
- if (of_find_property(dev->of_node, "ti,timer-secure", NULL))
+ if (of_property_read_bool(dev->of_node, "ti,timer-secure"))
timer->capability |= OMAP_TIMER_SECURE;
} else {
timer->id = pdev->id;
--
2.39.2

2023-04-18 16:26:39

by Rob Herring (Arm)

Subject: Re: [PATCH] clocksource: ti: Use of_property_read_bool() for boolean properties

On Fri, Mar 10, 2023 at 08:47:01AM -0600, Rob Herring wrote:
> It is preferred to use typed property access functions (i.e.
> of_property_read_<type> functions) rather than low-level
> of_get_property/of_find_property functions for reading properties.
> Convert reading boolean properties to to of_property_read_bool().
>
> Signed-off-by: Rob Herring <[email protected]>
> ---
> drivers/clocksource/timer-ti-dm-systimer.c | 4 ++--
> drivers/clocksource/timer-ti-dm.c | 8 ++++----
> 2 files changed, 6 insertions(+), 6 deletions(-)

Ping!

>
> diff --git a/drivers/clocksource/timer-ti-dm-systimer.c b/drivers/clocksource/timer-ti-dm-systimer.c
> index 632523c1232f..efa5f55a65f8 100644
> --- a/drivers/clocksource/timer-ti-dm-systimer.c
> +++ b/drivers/clocksource/timer-ti-dm-systimer.c
> @@ -586,7 +586,7 @@ static int __init dmtimer_clkevt_init_common(struct dmtimer_clockevent *clkevt,
> writel_relaxed(OMAP_TIMER_INT_OVERFLOW, t->base + t->wakeup);
>
> pr_info("TI gptimer %s: %s%lu Hz at %pOF\n",
> - name, of_find_property(np, "ti,timer-alwon", NULL) ?
> + name, of_property_read_bool(np, "ti,timer-alwon") ?
> "always-on " : "", t->rate, np->parent);
>
> return 0;
> @@ -787,7 +787,7 @@ static int __init dmtimer_clocksource_init(struct device_node *np)
> t->base + t->ctrl);
>
> pr_info("TI gptimer clocksource: %s%pOF\n",
> - of_find_property(np, "ti,timer-alwon", NULL) ?
> + of_property_read_bool(np, "ti,timer-alwon") ?
> "always-on " : "", np->parent);
>
> if (!dmtimer_sched_clock_counter) {
> diff --git a/drivers/clocksource/timer-ti-dm.c b/drivers/clocksource/timer-ti-dm.c
> index b24b903a8822..7031aa1bfdcb 100644
> --- a/drivers/clocksource/timer-ti-dm.c
> +++ b/drivers/clocksource/timer-ti-dm.c
> @@ -1104,13 +1104,13 @@ static int omap_dm_timer_probe(struct platform_device *pdev)
> platform_set_drvdata(pdev, timer);
>
> if (dev->of_node) {
> - if (of_find_property(dev->of_node, "ti,timer-alwon", NULL))
> + if (of_property_read_bool(dev->of_node, "ti,timer-alwon"))
> timer->capability |= OMAP_TIMER_ALWON;
> - if (of_find_property(dev->of_node, "ti,timer-dsp", NULL))
> + if (of_property_read_bool(dev->of_node, "ti,timer-dsp"))
> timer->capability |= OMAP_TIMER_HAS_DSP_IRQ;
> - if (of_find_property(dev->of_node, "ti,timer-pwm", NULL))
> + if (of_property_read_bool(dev->of_node, "ti,timer-pwm"))
> timer->capability |= OMAP_TIMER_HAS_PWM;
> - if (of_find_property(dev->of_node, "ti,timer-secure", NULL))
> + if (of_property_read_bool(dev->of_node, "ti,timer-secure"))
> timer->capability |= OMAP_TIMER_SECURE;
> } else {
> timer->id = pdev->id;
> --
> 2.39.2
>

2023-04-19 07:53:23

by Daniel Lezcano

Subject: Re: [PATCH] clocksource: ti: Use of_property_read_bool() for boolean properties

On 18/04/2023 18:24, Rob Herring wrote:
> On Fri, Mar 10, 2023 at 08:47:01AM -0600, Rob Herring wrote:
>> It is preferred to use typed property access functions (i.e.
>> of_property_read_<type> functions) rather than low-level
>> of_get_property/of_find_property functions for reading properties.
>> Convert reading boolean properties to to of_property_read_bool().
>>
>> Signed-off-by: Rob Herring <[email protected]>
>> ---
>> drivers/clocksource/timer-ti-dm-systimer.c | 4 ++--
>> drivers/clocksource/timer-ti-dm.c | 8 ++++----
>> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> Ping!

Applied, thanks for heads up


--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

2023-04-26 09:13:44

by tip-bot2 for Alexey Makhalov

Subject: [tip: timers/core] clocksource/drivers/ti: Use of_property_read_bool() for boolean properties

The following commit has been merged into the timers/core branch of tip:

Commit-ID: 87dd04f9b1a37a92ebbea5eb46e4941551d3547e
Gitweb: https://git.kernel.org/tip/87dd04f9b1a37a92ebbea5eb46e4941551d3547e
Author: Rob Herring <[email protected]>
AuthorDate: Fri, 10 Mar 2023 08:47:01 -06:00
Committer: Daniel Lezcano <[email protected]>
CommitterDate: Mon, 24 Apr 2023 16:56:14 +02:00

clocksource/drivers/ti: Use of_property_read_bool() for boolean properties

It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties.
Convert reading boolean properties to to of_property_read_bool().

Signed-off-by: Rob Herring <[email protected]>
Signed-off-by: Daniel Lezcano <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
---
drivers/clocksource/timer-ti-dm-systimer.c | 4 ++--
drivers/clocksource/timer-ti-dm.c | 8 ++++----
2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/clocksource/timer-ti-dm-systimer.c b/drivers/clocksource/timer-ti-dm-systimer.c
index 4fa68f6..c2dcd8d 100644
--- a/drivers/clocksource/timer-ti-dm-systimer.c
+++ b/drivers/clocksource/timer-ti-dm-systimer.c
@@ -584,7 +584,7 @@ static int __init dmtimer_clkevt_init_common(struct dmtimer_clockevent *clkevt,
writel_relaxed(OMAP_TIMER_INT_OVERFLOW, t->base + t->wakeup);

pr_info("TI gptimer %s: %s%lu Hz at %pOF\n",
- name, of_find_property(np, "ti,timer-alwon", NULL) ?
+ name, of_property_read_bool(np, "ti,timer-alwon") ?
"always-on " : "", t->rate, np->parent);

return 0;
@@ -785,7 +785,7 @@ static int __init dmtimer_clocksource_init(struct device_node *np)
t->base + t->ctrl);

pr_info("TI gptimer clocksource: %s%pOF\n",
- of_find_property(np, "ti,timer-alwon", NULL) ?
+ of_property_read_bool(np, "ti,timer-alwon") ?
"always-on " : "", np->parent);

if (!dmtimer_sched_clock_counter) {
diff --git a/drivers/clocksource/timer-ti-dm.c b/drivers/clocksource/timer-ti-dm.c
index ab7a6ca..1d3ad51 100644
--- a/drivers/clocksource/timer-ti-dm.c
+++ b/drivers/clocksource/timer-ti-dm.c
@@ -1104,13 +1104,13 @@ static int omap_dm_timer_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, timer);

if (dev->of_node) {
- if (of_find_property(dev->of_node, "ti,timer-alwon", NULL))
+ if (of_property_read_bool(dev->of_node, "ti,timer-alwon"))
timer->capability |= OMAP_TIMER_ALWON;
- if (of_find_property(dev->of_node, "ti,timer-dsp", NULL))
+ if (of_property_read_bool(dev->of_node, "ti,timer-dsp"))
timer->capability |= OMAP_TIMER_HAS_DSP_IRQ;
- if (of_find_property(dev->of_node, "ti,timer-pwm", NULL))
+ if (of_property_read_bool(dev->of_node, "ti,timer-pwm"))
timer->capability |= OMAP_TIMER_HAS_PWM;
- if (of_find_property(dev->of_node, "ti,timer-secure", NULL))
+ if (of_property_read_bool(dev->of_node, "ti,timer-secure"))
timer->capability |= OMAP_TIMER_SECURE;
} else {
timer->id = pdev->id;