2022-04-12 09:31:31

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH v2] arm64: dts: meson-sm1-bananapi-m5: fix wrong GPIO pin labeling for CON1

On 11/04/2022 16:44, Guillaume Giraudon wrote:
> The labels for lines 61 through 84 on the periphs-banks were offset by 2.
> 2 lines are missing in the BOOT GPIO lines (contains 14, should be 16)
> Added 2 empty entries in BOOT to realigned the rest of GPIO labels
> to match the Banana Pi M5 schematics.
>
> (Thanks to Neil Armstrong for the heads up on the position of the missing pins)
>
> Fixes: 976e920183e4 ("arm64: dts: meson-sm1: add Banana PI BPI-M5 board dts")
>
> Signed-off-by: Guillaume Giraudon <[email protected]>
> ---
> arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts
> index 5751c48620ed..84489525c75f 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts
> @@ -437,6 +437,7 @@
> "",
> "eMMC_RST#", /* BOOT_12 */
> "eMMC_DS", /* BOOT_13 */
> + "","",

Missing space after first comma, will add while applying.

> /* GPIOC */
> "SD_D0_B", /* GPIOC_0 */
> "SD_D1_B", /* GPIOC_1 */

Reviewed-by: Neil Armstrong <[email protected]>