2007-10-23 00:36:13

by Latchesar Ionkov

Subject: [PATCH] 9p: v9fs_vfs_rename incorrect clunk order

In v9fs_vfs_rename function labels don't match the fids that are clunked.
The correct clunk order is clunking newdirfid first and then olddirfid next.

Signed-off-by: Latchesar Ionkov <[email protected]>

---
commit 0c9269a1384273b7a409a2163fdf91cd39092889
tree 8a4984196ccb7ed027c086a53866e5582835e61f
parent 55b70a0300b873c0ec7ea6e33752af56f41250ce
author Latchesar Ionkov <[email protected]> Mon, 22 Oct 2007 18:11:19 -0600
committer Latchesar Ionkov <[email protected]> Mon, 22 Oct 2007 18:11:19 -0600

fs/9p/vfs_inode.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c
index 175b4d9..23581bc 100644
--- a/fs/9p/vfs_inode.c
+++ b/fs/9p/vfs_inode.c
@@ -687,10 +687,10 @@ v9fs_vfs_rename(struct inode *old_dir, struct dentry *old_dentry,
retval = p9_client_wstat(oldfid, &wstat);

clunk_newdir:
- p9_client_clunk(olddirfid);
+ p9_client_clunk(newdirfid);

clunk_olddir:
- p9_client_clunk(newdirfid);
+ p9_client_clunk(olddirfid);

done:
return retval;

2007-10-23 22:30:21

by Eric Van Hensbergen

Subject: Re: [V9fs-developer] [PATCH] 9p: v9fs_vfs_rename incorrect clunk order

On 10/22/07, Latchesar Ionkov <[email protected]> wrote:
> In v9fs_vfs_rename function labels don't match the fids that are clunked.
> The correct clunk order is clunking newdirfid first and then olddirfid next.
>
> Signed-off-by: Latchesar Ionkov <[email protected]>
Acked-by: Eric Van Hensbergen <[email protected]>