2024-06-05 10:12:22

by Neil Armstrong

Subject: [PATCH] dt-bindings: usb: dwc2: allow device sub-nodes

Allow the '#address-cells', '#size-cells' and subnodes as defined in
usb-hcd.yaml and used in the meson-gxbb-odroidc2 DT.

The fixes the following:
meson-gxbb-odroidc2.dtb: usb@c9100000: '#address-cells', '#size-cells', 'hub@1' do not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/usb/dwc2.yaml#

Signed-off-by: Neil Armstrong <[email protected]>
---
Documentation/devicetree/bindings/usb/dwc2.yaml | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/dwc2.yaml b/Documentation/devicetree/bindings/usb/dwc2.yaml
index 4f36a22aa6d7..9e737f587664 100644
--- a/Documentation/devicetree/bindings/usb/dwc2.yaml
+++ b/Documentation/devicetree/bindings/usb/dwc2.yaml
@@ -177,6 +177,13 @@ properties:
minItems: 1
maxItems: 2

+ "#address-cells": true
+
+ "#size-cells": true
+
+patternProperties:
+ "^.*@[0-9a-f]{1,2}$": true
+
dependencies:
port: [ usb-role-switch ]
role-switch-default-mode: [ usb-role-switch ]

---
base-commit: c3f38fa61af77b49866b006939479069cd451173
change-id: 20240605-topic-amlogic-upstream-bindings-fixes-dwc2-subnodes-4a68ead79624

Best regards,
--
Neil Armstrong <[email protected]>

2024-06-06 00:40:27

by Rob Herring (Arm)

Subject: Re: [PATCH] dt-bindings: usb: dwc2: allow device sub-nodes

On Wed, Jun 05, 2024 at 12:01:20PM +0200, Neil Armstrong wrote:
> Allow the '#address-cells', '#size-cells' and subnodes as defined in
> usb-hcd.yaml and used in the meson-gxbb-odroidc2 DT.

Doesn't referencing usb-hcd.yaml instead work? Or you need
unevaluatedProperties?

>
> The fixes the following:
> meson-gxbb-odroidc2.dtb: usb@c9100000: '#address-cells', '#size-cells', 'hub@1' do not match any of the regexes: 'pinctrl-[0-9]+'
> from schema $id: http://devicetree.org/schemas/usb/dwc2.yaml#
>
> Signed-off-by: Neil Armstrong <[email protected]>
> ---
> Documentation/devicetree/bindings/usb/dwc2.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/dwc2.yaml b/Documentation/devicetree/bindings/usb/dwc2.yaml
> index 4f36a22aa6d7..9e737f587664 100644
> --- a/Documentation/devicetree/bindings/usb/dwc2.yaml
> +++ b/Documentation/devicetree/bindings/usb/dwc2.yaml
> @@ -177,6 +177,13 @@ properties:
> minItems: 1
> maxItems: 2
>
> + "#address-cells": true
> +
> + "#size-cells": true
> +
> +patternProperties:
> + "^.*@[0-9a-f]{1,2}$": true
> +
> dependencies:
> port: [ usb-role-switch ]
> role-switch-default-mode: [ usb-role-switch ]
>
> ---
> base-commit: c3f38fa61af77b49866b006939479069cd451173
> change-id: 20240605-topic-amlogic-upstream-bindings-fixes-dwc2-subnodes-4a68ead79624
>
> Best regards,
> --
> Neil Armstrong <[email protected]>
>

2024-06-06 07:55:49

by Neil Armstrong

Subject: Re: [PATCH] dt-bindings: usb: dwc2: allow device sub-nodes

On 06/06/2024 02:40, Rob Herring wrote:
> On Wed, Jun 05, 2024 at 12:01:20PM +0200, Neil Armstrong wrote:
>> Allow the '#address-cells', '#size-cells' and subnodes as defined in
>> usb-hcd.yaml and used in the meson-gxbb-odroidc2 DT.
>
> Doesn't referencing usb-hcd.yaml instead work? Or you need
> unevaluatedProperties?


I realized after my dt-schema was too old, and updating it fixes the problem...

Please ignore this patch,

Thanks,
Neil

>
>>
>> The fixes the following:
>> meson-gxbb-odroidc2.dtb: usb@c9100000: '#address-cells', '#size-cells', 'hub@1' do not match any of the regexes: 'pinctrl-[0-9]+'
>> from schema $id: http://devicetree.org/schemas/usb/dwc2.yaml#
>>
>> Signed-off-by: Neil Armstrong <[email protected]>
>> ---
>> Documentation/devicetree/bindings/usb/dwc2.yaml | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/dwc2.yaml b/Documentation/devicetree/bindings/usb/dwc2.yaml
>> index 4f36a22aa6d7..9e737f587664 100644
>> --- a/Documentation/devicetree/bindings/usb/dwc2.yaml
>> +++ b/Documentation/devicetree/bindings/usb/dwc2.yaml
>> @@ -177,6 +177,13 @@ properties:
>> minItems: 1
>> maxItems: 2
>>
>> + "#address-cells": true
>> +
>> + "#size-cells": true
>> +
>> +patternProperties:
>> + "^.*@[0-9a-f]{1,2}$": true
>> +
>> dependencies:
>> port: [ usb-role-switch ]
>> role-switch-default-mode: [ usb-role-switch ]
>>
>> ---
>> base-commit: c3f38fa61af77b49866b006939479069cd451173
>> change-id: 20240605-topic-amlogic-upstream-bindings-fixes-dwc2-subnodes-4a68ead79624
>>
>> Best regards,
>> --
>> Neil Armstrong <[email protected]>
>>