2022-05-09 07:13:15

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v3 1/3] dt-bindings: soc: add bindings for Intel HPS Copy Engine

On 06/05/2022 17:41, [email protected] wrote:
> From: Matthew Gerlach <[email protected]>
>
> Add device tree bindings documentation for the Intel Hard
> Processor System (HPS) Copy Engine.
>
> Signed-off-by: Matthew Gerlach <[email protected]>
> ---
> v3:
> - remove unused label
> - move from misc to soc
> - remove 0x from #address-cells/#size-cells values
> - change hps_cp_eng@0 to dma-controller@0
> - remote inaccurate 'items:' tag
> ---
> .../bindings/soc/intel,hps-copy-engine.yaml | 51 +++++++++++++++++++
> 1 file changed, 51 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/intel,hps-copy-engine.yaml

There are no files laying around in bindings/soc. Each is in its own
vendor subdirectory, so let's don't introduce inconsistencies. Intel
should not be different/special.

Best regards,
Krzysztof


2022-05-09 09:59:56

by Matthew Gerlach

[permalink] [raw]
Subject: Re: [PATCH v3 1/3] dt-bindings: soc: add bindings for Intel HPS Copy Engine



On Sat, 7 May 2022, Krzysztof Kozlowski wrote:

> On 06/05/2022 17:41, [email protected] wrote:
>> From: Matthew Gerlach <[email protected]>
>>
>> Add device tree bindings documentation for the Intel Hard
>> Processor System (HPS) Copy Engine.
>>
>> Signed-off-by: Matthew Gerlach <[email protected]>
>> ---
>> v3:
>> - remove unused label
>> - move from misc to soc
>> - remove 0x from #address-cells/#size-cells values
>> - change hps_cp_eng@0 to dma-controller@0
>> - remote inaccurate 'items:' tag
>> ---
>> .../bindings/soc/intel,hps-copy-engine.yaml | 51 +++++++++++++++++++
>> 1 file changed, 51 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/soc/intel,hps-copy-engine.yaml
>
> There are no files laying around in bindings/soc. Each is in its own
> vendor subdirectory, so let's don't introduce inconsistencies. Intel
> should not be different/special.

I certainly don't want to be different or special. I will move the file
to an intel subdirectory.

Thanks for the feedback,
Matthew

>
> Best regards,
> Krzysztof
>