2020-01-17 04:04:57

by Yue Haibing

[permalink] [raw]
Subject: [PATCH -next] video: fbdev: pxa168fb: remove unnecessary platform_get_irq

commit 640ba2444fa9 ("drivers/video/pxa168fb.c: use devm_ functions")
left behind this, it can be removed.

Signed-off-by: YueHaibing <[email protected]>
---
drivers/video/fbdev/pxa168fb.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/video/fbdev/pxa168fb.c b/drivers/video/fbdev/pxa168fb.c
index 706c6943..aef8a30 100644
--- a/drivers/video/fbdev/pxa168fb.c
+++ b/drivers/video/fbdev/pxa168fb.c
@@ -779,7 +779,6 @@ static int pxa168fb_remove(struct platform_device *pdev)
{
struct pxa168fb_info *fbi = platform_get_drvdata(pdev);
struct fb_info *info;
- int irq;
unsigned int data;

if (!fbi)
@@ -799,8 +798,6 @@ static int pxa168fb_remove(struct platform_device *pdev)
if (info->cmap.len)
fb_dealloc_cmap(&info->cmap);

- irq = platform_get_irq(pdev, 0);
-
dma_free_wc(fbi->dev, info->fix.smem_len,
info->screen_base, info->fix.smem_start);

--
2.7.4



Subject: Re: [PATCH -next] video: fbdev: pxa168fb: remove unnecessary platform_get_irq


On 1/17/20 4:22 AM, YueHaibing wrote:
> commit 640ba2444fa9 ("drivers/video/pxa168fb.c: use devm_ functions")
> left behind this, it can be removed.
>
> Signed-off-by: YueHaibing <[email protected]>

Patch queued for v5.7, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> ---
> drivers/video/fbdev/pxa168fb.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/video/fbdev/pxa168fb.c b/drivers/video/fbdev/pxa168fb.c
> index 706c6943..aef8a30 100644
> --- a/drivers/video/fbdev/pxa168fb.c
> +++ b/drivers/video/fbdev/pxa168fb.c
> @@ -779,7 +779,6 @@ static int pxa168fb_remove(struct platform_device *pdev)
> {
> struct pxa168fb_info *fbi = platform_get_drvdata(pdev);
> struct fb_info *info;
> - int irq;
> unsigned int data;
>
> if (!fbi)
> @@ -799,8 +798,6 @@ static int pxa168fb_remove(struct platform_device *pdev)
> if (info->cmap.len)
> fb_dealloc_cmap(&info->cmap);
>
> - irq = platform_get_irq(pdev, 0);
> -
> dma_free_wc(fbi->dev, info->fix.smem_len,
> info->screen_base, info->fix.smem_start);
>