2023-06-03 03:56:03

by Miaohe Lin

Subject: [PATCH v2] x86/mce: remove unused mce_vaddr

Since commit a6e3cf70b772 ("x86/mce: Change to not send SIGBUS error during
copy from user"), mce_vaddr is not used anymore. Remove it.

Signed-off-by: Miaohe Lin <[email protected]>
---
arch/x86/kernel/cpu/mce/severity.c | 2 --
include/linux/sched.h | 1 -
2 files changed, 3 deletions(-)

diff --git a/arch/x86/kernel/cpu/mce/severity.c b/arch/x86/kernel/cpu/mce/severity.c
index c4477162c07d..1c03221ddcb1 100644
--- a/arch/x86/kernel/cpu/mce/severity.c
+++ b/arch/x86/kernel/cpu/mce/severity.c
@@ -255,8 +255,6 @@ static bool is_copy_from_user(struct pt_regs *regs)
if (fault_in_kernel_space(addr))
return false;

- current->mce_vaddr = (void __user *)addr;
-
return true;
}

diff --git a/include/linux/sched.h b/include/linux/sched.h
index eed5d65b8d1f..3054a7087230 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -1493,7 +1493,6 @@ struct task_struct {
#endif

#ifdef CONFIG_X86_MCE
- void __user *mce_vaddr;
__u64 mce_kflags;
u64 mce_addr;
__u64 mce_ripv : 1,
--
2.27.0

2023-06-15 11:24:47

by Miaohe Lin

Subject: Re: [PATCH v2] x86/mce: remove unused mce_vaddr

On 2023/6/3 19:11, Miaohe Lin wrote:
> Since commit a6e3cf70b772 ("x86/mce: Change to not send SIGBUS error during
> copy from user"), mce_vaddr is not used anymore. Remove it.
>

friendly ping.. :)

> Signed-off-by: Miaohe Lin <[email protected]>
> ---
> arch/x86/kernel/cpu/mce/severity.c | 2 --
> include/linux/sched.h | 1 -
> 2 files changed, 3 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/mce/severity.c b/arch/x86/kernel/cpu/mce/severity.c
> index c4477162c07d..1c03221ddcb1 100644
> --- a/arch/x86/kernel/cpu/mce/severity.c
> +++ b/arch/x86/kernel/cpu/mce/severity.c
> @@ -255,8 +255,6 @@ static bool is_copy_from_user(struct pt_regs *regs)
> if (fault_in_kernel_space(addr))
> return false;
>
> - current->mce_vaddr = (void __user *)addr;
> -
> return true;
> }
>
> diff --git a/include/linux/sched.h b/include/linux/sched.h
> index eed5d65b8d1f..3054a7087230 100644
> --- a/include/linux/sched.h
> +++ b/include/linux/sched.h
> @@ -1493,7 +1493,6 @@ struct task_struct {
> #endif
>
> #ifdef CONFIG_X86_MCE
> - void __user *mce_vaddr;
> __u64 mce_kflags;
> u64 mce_addr;
> __u64 mce_ripv : 1,
>