Hi Lukas,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 42e66b1cc3a070671001f8a1e933a80818a192bf
commit: 899596e090ea21918c55cbccea594be840af44ea ACPI / property: Support Apple _DSM properties
date: 5 years ago
config: i386-randconfig-a002 (https://download.01.org/0day-ci/archive/20220902/[email protected]/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build):
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=899596e090ea21918c55cbccea594be840af44ea
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 899596e090ea21918c55cbccea594be840af44ea
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash arch/x86/kernel/cpu/ arch/x86/kvm/ drivers/acpi/ virt/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <[email protected]>
All warnings (new ones prefixed by >>):
>> drivers/acpi/x86/apple.c:30:6: warning: no previous declaration for 'acpi_extract_apple_properties' [-Wmissing-declarations]
void acpi_extract_apple_properties(struct acpi_device *adev)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/acpi_extract_apple_properties +30 drivers/acpi/x86/apple.c
14
15 /* Apple _DSM device properties GUID */
16 static const guid_t apple_prp_guid =
17 GUID_INIT(0xa0b5b7c6, 0x1318, 0x441c,
18 0xb0, 0xc9, 0xfe, 0x69, 0x5e, 0xaf, 0x94, 0x9b);
19
20 /**
21 * acpi_extract_apple_properties - retrieve and convert Apple _DSM properties
22 * @adev: ACPI device for which to retrieve the properties
23 *
24 * Invoke Apple's custom _DSM once to check the protocol version and once more
25 * to retrieve the properties. They are marshalled up in a single package as
26 * alternating key/value elements, unlike _DSD which stores them as a package
27 * of 2-element packages. Convert to _DSD format and make them available under
28 * the primary fwnode.
29 */
> 30 void acpi_extract_apple_properties(struct acpi_device *adev)
--
0-DAY CI Kernel Test Service
https://01.org/lkp
Silence an annoying message emitted for W=1 builds:
drivers/acpi/x86/apple.c:30:6: warning: no previous declaration for 'acpi_extract_apple_properties' [-Wmissing-declarations]
Reported-by: kernel test robot <[email protected]>
Signed-off-by: Lukas Wunner <[email protected]>
---
drivers/acpi/x86/apple.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/acpi/x86/apple.c b/drivers/acpi/x86/apple.c
index c285c91a5e9c..8812ecd03d55 100644
--- a/drivers/acpi/x86/apple.c
+++ b/drivers/acpi/x86/apple.c
@@ -8,6 +8,7 @@
#include <linux/bitmap.h>
#include <linux/platform_data/x86/apple.h>
#include <linux/uuid.h>
+#include "../internal.h"
/* Apple _DSM device properties GUID */
static const guid_t apple_prp_guid =
--
2.36.1
On Fri, Sep 02, 2022 at 04:15:55AM +0200, Lukas Wunner wrote:
> Silence an annoying message emitted for W=1 builds:
>
> drivers/acpi/x86/apple.c:30:6: warning: no previous declaration for 'acpi_extract_apple_properties' [-Wmissing-declarations]
Reviewed-by: Andy Shevchenko <[email protected]>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Lukas Wunner <[email protected]>
> ---
> drivers/acpi/x86/apple.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/acpi/x86/apple.c b/drivers/acpi/x86/apple.c
> index c285c91a5e9c..8812ecd03d55 100644
> --- a/drivers/acpi/x86/apple.c
> +++ b/drivers/acpi/x86/apple.c
> @@ -8,6 +8,7 @@
> #include <linux/bitmap.h>
> #include <linux/platform_data/x86/apple.h>
> #include <linux/uuid.h>
> +#include "../internal.h"
>
> /* Apple _DSM device properties GUID */
> static const guid_t apple_prp_guid =
> --
> 2.36.1
>
--
With Best Regards,
Andy Shevchenko
On Fri, Sep 2, 2022 at 11:50 AM Andy Shevchenko
<[email protected]> wrote:
>
> On Fri, Sep 02, 2022 at 04:15:55AM +0200, Lukas Wunner wrote:
> > Silence an annoying message emitted for W=1 builds:
> >
> > drivers/acpi/x86/apple.c:30:6: warning: no previous declaration for 'acpi_extract_apple_properties' [-Wmissing-declarations]
>
> Reviewed-by: Andy Shevchenko <[email protected]>
>
> > Reported-by: kernel test robot <[email protected]>
> > Signed-off-by: Lukas Wunner <[email protected]>
> > ---
> > drivers/acpi/x86/apple.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/acpi/x86/apple.c b/drivers/acpi/x86/apple.c
> > index c285c91a5e9c..8812ecd03d55 100644
> > --- a/drivers/acpi/x86/apple.c
> > +++ b/drivers/acpi/x86/apple.c
> > @@ -8,6 +8,7 @@
> > #include <linux/bitmap.h>
> > #include <linux/platform_data/x86/apple.h>
> > #include <linux/uuid.h>
> > +#include "../internal.h"
> >
> > /* Apple _DSM device properties GUID */
> > static const guid_t apple_prp_guid =
> > --
Applied as 6.1 material, thanks!