2020-03-15 23:41:04

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build warning after merge of the mlx5-next tree

Hi all,

After merging the mlx5-next tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

In file included from include/linux/printk.h:331,
from include/linux/kernel.h:15,
from drivers/net/ethernet/mellanox/mlx5/core/mr.c:33:
drivers/net/ethernet/mellanox/mlx5/core/mr.c: In function 'mlx5_core_create_mkey':
include/linux/dynamic_debug.h:157:25: warning: 'key' may be used uninitialized in this function [-Wmaybe-uninitialized]
157 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlx5/core/mr.c:47:5: note: 'key' was declared here
47 | u8 key;
| ^~~

Probably introduced by commit

fc6a9f86f08a ("{IB,net}/mlx5: Assign mkey variant in mlx5_ib only")

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2020-03-18 02:06:39

by Stephen Rothwell

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the mlx5-next tree

Hi all,

On Mon, 16 Mar 2020 10:39:13 +1100 Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> After merging the mlx5-next tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> In file included from include/linux/printk.h:331,
> from include/linux/kernel.h:15,
> from drivers/net/ethernet/mellanox/mlx5/core/mr.c:33:
> drivers/net/ethernet/mellanox/mlx5/core/mr.c: In function 'mlx5_core_create_mkey':
> include/linux/dynamic_debug.h:157:25: warning: 'key' may be used uninitialized in this function [-Wmaybe-uninitialized]
> 157 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
> | ^~~~~~~~~~~~~~~~~
> drivers/net/ethernet/mellanox/mlx5/core/mr.c:47:5: note: 'key' was declared here
> 47 | u8 key;
> | ^~~
>
> Probably introduced by commit
>
> fc6a9f86f08a ("{IB,net}/mlx5: Assign mkey variant in mlx5_ib only")

This warning now appears in the rdma tree.

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2020-03-18 02:33:31

by Saeed Mahameed

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the mlx5-next tree

On Wed, 2020-03-18 at 13:05 +1100, Stephen Rothwell wrote:
> Hi all,
>
> On Mon, 16 Mar 2020 10:39:13 +1100 Stephen Rothwell <
> [email protected]> wrote:
> > Hi all,
> >
> > After merging the mlx5-next tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> >
> > In file included from include/linux/printk.h:331,
> > from include/linux/kernel.h:15,
> > from
> > drivers/net/ethernet/mellanox/mlx5/core/mr.c:33:
> > drivers/net/ethernet/mellanox/mlx5/core/mr.c: In function
> > 'mlx5_core_create_mkey':
> > include/linux/dynamic_debug.h:157:25: warning: 'key' may be used
> > uninitialized in this function [-Wmaybe-uninitialized]
> > 157 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
> > | ^~~~~~~~~~~~~~~~~
> > drivers/net/ethernet/mellanox/mlx5/core/mr.c:47:5: note: 'key' was
> > declared here
> > 47 | u8 key;
> > | ^~~
> >
> > Probably introduced by commit
> >
> > fc6a9f86f08a ("{IB,net}/mlx5: Assign mkey variant in mlx5_ib
> > only")
>
> This warning now appears in the rdma tree.
>

thanks Stephen,

actuall a fix patch was merged yesterday into mlx5-next [1]

and should already be in linux-next build, and will soon land in rdma
tree.

Thanks,
Saeed.

[1]
https://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.git/commit/?h=mlx5-next&id=826096d84f509d95ee8f72728fe19c44fbb9df6b