2024-01-11 11:08:25

by XueBing Chen

Subject: [PATCH] [media] Clean up errors in dib0090.h

Fix the following errors reported by checkpatch:

ERROR: "foo * bar" should be "foo *bar"

Signed-off-by: XueBing Chen <[email protected]>
---
drivers/media/dvb-frontends/dib0090.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/dvb-frontends/dib0090.h b/drivers/media/dvb-frontends/dib0090.h
index e5cb311694d9..613b0eb8c436 100644
--- a/drivers/media/dvb-frontends/dib0090.h
+++ b/drivers/media/dvb-frontends/dib0090.h
@@ -82,7 +82,7 @@ extern u16 dib0090_get_wbd_offset(struct dvb_frontend *fe);
extern int dib0090_gain_control(struct dvb_frontend *fe);
extern enum frontend_tune_state dib0090_get_tune_state(struct dvb_frontend *fe);
extern int dib0090_set_tune_state(struct dvb_frontend *fe, enum frontend_tune_state tune_state);
-extern void dib0090_get_current_gain(struct dvb_frontend *fe, u16 * rf, u16 * bb, u16 * rf_gain_limit, u16 * rflt);
+extern void dib0090_get_current_gain(struct dvb_frontend *fe, u16* rf, u16* bb, u16* rf_gain_limit, u16* rflt);
extern void dib0090_set_dc_servo(struct dvb_frontend *fe, u8 DC_servo_cutoff);
extern int dib0090_set_switch(struct dvb_frontend *fe, u8 sw1, u8 sw2, u8 sw3);
extern int dib0090_set_vga(struct dvb_frontend *fe, u8 onoff);
--
2.17.1

2024-02-12 14:56:48

by Hans Verkuil

Subject: Re: [PATCH] [media] Clean up errors in dib0090.h

Hi!

First of all, the proper subject prefix is "media:", and in this case I
would say: "media: dvb-frontends:".

On 11/01/2024 12:05, XueBing Chen wrote:
> Fix the following errors reported by checkpatch:
>
> ERROR: "foo * bar" should be "foo *bar"

Secondly, the error says that it should be "foo *bar"...

>
> Signed-off-by: XueBing Chen <[email protected]>
> ---
> drivers/media/dvb-frontends/dib0090.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/dvb-frontends/dib0090.h b/drivers/media/dvb-frontends/dib0090.h
> index e5cb311694d9..613b0eb8c436 100644
> --- a/drivers/media/dvb-frontends/dib0090.h
> +++ b/drivers/media/dvb-frontends/dib0090.h
> @@ -82,7 +82,7 @@ extern u16 dib0090_get_wbd_offset(struct dvb_frontend *fe);
> extern int dib0090_gain_control(struct dvb_frontend *fe);
> extern enum frontend_tune_state dib0090_get_tune_state(struct dvb_frontend *fe);
> extern int dib0090_set_tune_state(struct dvb_frontend *fe, enum frontend_tune_state tune_state);
> -extern void dib0090_get_current_gain(struct dvb_frontend *fe, u16 * rf, u16 * bb, u16 * rf_gain_limit, u16 * rflt);
> +extern void dib0090_get_current_gain(struct dvb_frontend *fe, u16* rf, u16* bb, u16* rf_gain_limit, u16* rflt);

..so why do you write "foo* bar"???

Regards,

Hans

> extern void dib0090_set_dc_servo(struct dvb_frontend *fe, u8 DC_servo_cutoff);
> extern int dib0090_set_switch(struct dvb_frontend *fe, u8 sw1, u8 sw2, u8 sw3);
> extern int dib0090_set_vga(struct dvb_frontend *fe, u8 onoff);