2023-06-19 15:35:15

by Yunlei He

Subject: [f2fs-dev][PATCH] f2fs: remove unneeded page uptodate check/set

This patch remove unneeded page uptodate check/set in
f2fs_vm_page_mkwrite, which already done in set_page_dirty.

Signed-off-by: Yunlei He <[email protected]>
---
fs/f2fs/file.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 147ab24ae579..b3e96bceaef2 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -149,8 +149,6 @@ static vm_fault_t f2fs_vm_page_mkwrite(struct vm_fault *vmf)
zero_user_segment(page, offset, PAGE_SIZE);
}
set_page_dirty(page);
- if (!PageUptodate(page))
- SetPageUptodate(page);

out_sem:
f2fs_update_iostat(sbi, inode, APP_MAPPED_IO, F2FS_BLKSIZE);
--
2.40.1

2023-06-20 09:49:37

by Chao Yu

Subject: Re: [f2fs-dev][PATCH] f2fs: remove unneeded page uptodate check/set

On 2023/6/19 23:13, Yunlei He wrote:
> This patch remove unneeded page uptodate check/set in
> f2fs_vm_page_mkwrite, which already done in set_page_dirty.
>
> Signed-off-by: Yunlei He <[email protected]>

Reviewed-by: Chao Yu <[email protected]>

Thanks,