2020-02-07 22:14:45

by Andrew Maier

Subject: [PATCH v2] PCI/P2PDMA: Add the remaining Intel Sky Lake-E root ports to the whitelist

Add the three remaining Intel Sky Lake-E host root ports to the
whitelist of p2pdma.

P2P has been tested and is working on this system.

Signed-off-by: Andrew Maier <[email protected]>
---
Resending this as I rebased it onto the latest patches.
drivers/pci/p2pdma.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c
index 9a8a38384121..b73b10bce0df 100644
--- a/drivers/pci/p2pdma.c
+++ b/drivers/pci/p2pdma.c
@@ -291,6 +291,9 @@ static const struct pci_p2pdma_whitelist_entry {
{PCI_VENDOR_ID_INTEL, 0x2f01, REQ_SAME_HOST_BRIDGE},
/* Intel SkyLake-E */
{PCI_VENDOR_ID_INTEL, 0x2030, 0},
+ {PCI_VENDOR_ID_INTEL, 0x2031, 0},
+ {PCI_VENDOR_ID_INTEL, 0x2032, 0},
+ {PCI_VENDOR_ID_INTEL, 0x2033, 0},
{PCI_VENDOR_ID_INTEL, 0x2020, 0},
{}
};
--
2.17.1

2020-02-07 22:21:47

by Logan Gunthorpe

Subject: Re: [PATCH v2] PCI/P2PDMA: Add the remaining Intel Sky Lake-E root ports to the whitelist

+cc Armen

On 2020-02-07 3:12 p.m., Andrew Maier wrote:
> Add the three remaining Intel Sky Lake-E host root ports to the
> whitelist of p2pdma.
>
> P2P has been tested and is working on this system.
>
> Signed-off-by: Andrew Maier <[email protected]>
> ---
> Resending this as I rebased it onto the latest patches.

Right, this is the same machine Armen already sent, so I've CC'd him.

Looks like we're just adding the extra possible root ports from the PCI
IDs database:

2031 Sky Lake-E PCI Express Root Port B
2032 Sky Lake-E PCI Express Root Port C
2033 Sky Lake-E PCI Express Root Port D

Makes sense to me, thanks,

Reviewed-by: Logan Gunthorpe <[email protected]>

> drivers/pci/p2pdma.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c
> index 9a8a38384121..b73b10bce0df 100644
> --- a/drivers/pci/p2pdma.c
> +++ b/drivers/pci/p2pdma.c
> @@ -291,6 +291,9 @@ static const struct pci_p2pdma_whitelist_entry {
> {PCI_VENDOR_ID_INTEL, 0x2f01, REQ_SAME_HOST_BRIDGE},
> /* Intel SkyLake-E */
> {PCI_VENDOR_ID_INTEL, 0x2030, 0},
> + {PCI_VENDOR_ID_INTEL, 0x2031, 0},
> + {PCI_VENDOR_ID_INTEL, 0x2032, 0},
> + {PCI_VENDOR_ID_INTEL, 0x2033, 0},
> {PCI_VENDOR_ID_INTEL, 0x2020, 0},
> {}
> };
>

2020-03-18 23:14:21

by Bjorn Helgaas

Subject: Re: [PATCH v2] PCI/P2PDMA: Add the remaining Intel Sky Lake-E root ports to the whitelist

On Fri, Feb 07, 2020 at 03:12:19PM -0700, Andrew Maier wrote:
> Add the three remaining Intel Sky Lake-E host root ports to the
> whitelist of p2pdma.
>
> P2P has been tested and is working on this system.
>
> Signed-off-by: Andrew Maier <[email protected]>

Applied with Logan's reviewed-by to pci/p2pdma for v5.7, thanks!

> ---
> Resending this as I rebased it onto the latest patches.
> drivers/pci/p2pdma.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c
> index 9a8a38384121..b73b10bce0df 100644
> --- a/drivers/pci/p2pdma.c
> +++ b/drivers/pci/p2pdma.c
> @@ -291,6 +291,9 @@ static const struct pci_p2pdma_whitelist_entry {
> {PCI_VENDOR_ID_INTEL, 0x2f01, REQ_SAME_HOST_BRIDGE},
> /* Intel SkyLake-E */
> {PCI_VENDOR_ID_INTEL, 0x2030, 0},
> + {PCI_VENDOR_ID_INTEL, 0x2031, 0},
> + {PCI_VENDOR_ID_INTEL, 0x2032, 0},
> + {PCI_VENDOR_ID_INTEL, 0x2033, 0},
> {PCI_VENDOR_ID_INTEL, 0x2020, 0},
> {}
> };
> --
> 2.17.1
>