2023-04-21 22:33:57

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH] arm64: dts: ti: add missing cache properties

As all level 2 and level 3 caches are unified, add required
cache-unified properties to fix warnings like:

k3-am6528-iot2050-basic-pg2.dtb: l3-cache0: 'cache-unified' is a required property

Signed-off-by: Krzysztof Kozlowski <[email protected]>

---

Please take the patch via sub-arch SoC tree.
---
arch/arm64/boot/dts/ti/k3-am654.dtsi | 1 +
arch/arm64/boot/dts/ti/k3-j7200.dtsi | 1 +
arch/arm64/boot/dts/ti/k3-j721e.dtsi | 1 +
arch/arm64/boot/dts/ti/k3-j721s2.dtsi | 1 +
4 files changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am654.dtsi b/arch/arm64/boot/dts/ti/k3-am654.dtsi
index 4cc329b271ac..888567b921f0 100644
--- a/arch/arm64/boot/dts/ti/k3-am654.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am654.dtsi
@@ -113,6 +113,7 @@ L2_1: l2-cache1 {
msmc_l3: l3-cache0 {
compatible = "cache";
cache-level = <3>;
+ cache-unified;
};

thermal_zones: thermal-zones {
diff --git a/arch/arm64/boot/dts/ti/k3-j7200.dtsi b/arch/arm64/boot/dts/ti/k3-j7200.dtsi
index bbe380c72a7e..f1836ec8e934 100644
--- a/arch/arm64/boot/dts/ti/k3-j7200.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j7200.dtsi
@@ -95,6 +95,7 @@ L2_0: l2-cache0 {
msmc_l3: l3-cache0 {
compatible = "cache";
cache-level = <3>;
+ cache-unified;
};

firmware {
diff --git a/arch/arm64/boot/dts/ti/k3-j721e.dtsi b/arch/arm64/boot/dts/ti/k3-j721e.dtsi
index b912143b6a11..c577f3739407 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721e.dtsi
@@ -97,6 +97,7 @@ L2_0: l2-cache0 {
msmc_l3: l3-cache0 {
compatible = "cache";
cache-level = <3>;
+ cache-unified;
};

firmware {
diff --git a/arch/arm64/boot/dts/ti/k3-j721s2.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2.dtsi
index 376924726f1f..f3db277628cd 100644
--- a/arch/arm64/boot/dts/ti/k3-j721s2.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721s2.dtsi
@@ -81,6 +81,7 @@ L2_0: l2-cache0 {
msmc_l3: l3-cache0 {
compatible = "cache";
cache-level = <3>;
+ cache-unified;
};

firmware {
--
2.34.1


2023-04-22 01:35:06

by Nishanth Menon

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: ti: add missing cache properties

On 00:31-20230422, Krzysztof Kozlowski wrote:
> As all level 2 and level 3 caches are unified, add required
> cache-unified properties to fix warnings like:
>
> k3-am6528-iot2050-basic-pg2.dtb: l3-cache0: 'cache-unified' is a required property
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
>
> Please take the patch via sub-arch SoC tree.

Acked-by: Nishanth Menon <[email protected]>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

2023-05-16 16:40:38

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: ti: add missing cache properties

On 22/04/2023 03:34, Nishanth Menon wrote:
> On 00:31-20230422, Krzysztof Kozlowski wrote:
>> As all level 2 and level 3 caches are unified, add required
>> cache-unified properties to fix warnings like:
>>
>> k3-am6528-iot2050-basic-pg2.dtb: l3-cache0: 'cache-unified' is a required property
>>
>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>>
>> ---
>>
>> Please take the patch via sub-arch SoC tree.
>
> Acked-by: Nishanth Menon <[email protected]>

sub-arch means TI... but ok, I'll grab it with the rest.


Best regards,
Krzysztof


2023-05-16 16:43:37

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: ti: add missing cache properties


On Sat, 22 Apr 2023 00:31:43 +0200, Krzysztof Kozlowski wrote:
> As all level 2 and level 3 caches are unified, add required
> cache-unified properties to fix warnings like:
>
> k3-am6528-iot2050-basic-pg2.dtb: l3-cache0: 'cache-unified' is a required property
>
>

Applied, thanks!

Please let me know if this should go through any other tree.

[1/1] arm64: dts: ti: add missing cache properties
https://git.kernel.org/krzk/linux-dt/c/be9633397b9f268242724a0c763839579761ee60

Best regards,
--
Krzysztof Kozlowski <[email protected]>

2023-05-16 17:28:29

by Vignesh Raghavendra

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: ti: add missing cache properties

Hi Krzysztof,

On 5/16/2023 10:09 PM, Krzysztof Kozlowski wrote:
>
> On Sat, 22 Apr 2023 00:31:43 +0200, Krzysztof Kozlowski wrote:
>> As all level 2 and level 3 caches are unified, add required
>> cache-unified properties to fix warnings like:
>>
>> k3-am6528-iot2050-basic-pg2.dtb: l3-cache0: 'cache-unified' is a required property
>>
>>
>
> Applied, thanks!
>
> Please let me know if this should go through any other tree.
>
> [1/1] arm64: dts: ti: add missing cache properties
> https://git.kernel.org/krzk/linux-dt/c/be9633397b9f268242724a0c763839579761ee60
>
> Best regards,


I have already queued it up at [0] for testing (should be part of linux-next already)..
I intend to send out this as part of fixes PR towards -rc3 tomo. Would you mind dropping this from your tree?

[0] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git/commit/?h=ti-k3-dts-next&id=27244f81d6f6abbf06fc705a940ba650fd687b9f

Regards
Vignesh

2023-05-16 17:44:43

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: ti: add missing cache properties

On 16/05/2023 19:04, Raghavendra, Vignesh wrote:
> Hi Krzysztof,
>
> On 5/16/2023 10:09 PM, Krzysztof Kozlowski wrote:
>>
>> On Sat, 22 Apr 2023 00:31:43 +0200, Krzysztof Kozlowski wrote:
>>> As all level 2 and level 3 caches are unified, add required
>>> cache-unified properties to fix warnings like:
>>>
>>> k3-am6528-iot2050-basic-pg2.dtb: l3-cache0: 'cache-unified' is a required property
>>>
>>>
>>
>> Applied, thanks!
>>
>> Please let me know if this should go through any other tree.
>>
>> [1/1] arm64: dts: ti: add missing cache properties
>> https://git.kernel.org/krzk/linux-dt/c/be9633397b9f268242724a0c763839579761ee60
>>
>> Best regards,
>
>
> I have already queued it up at [0] for testing (should be part of linux-next already)..
> I intend to send out this as part of fixes PR towards -rc3 tomo. Would you mind dropping this from your tree?
>
> [0] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git/commit/?h=ti-k3-dts-next&id=27244f81d6f6abbf06fc705a940ba650fd687b9f

Thanks for letting me know, I'll drop mine.

Best regards,
Krzysztof