2023-12-04 18:07:31

by George Stark

Subject: [PATCH v2 02/10] leds: aw2013: unlock mutex before destroying it

In the probe() callback in case of error mutex is destroyed being locked
which is not allowed so unlock the mute before destroying.

Signed-off-by: George Stark <[email protected]>
---
drivers/leds/leds-aw2013.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/leds/leds-aw2013.c b/drivers/leds/leds-aw2013.c
index 59765640b70f..c2bc0782c0cd 100644
--- a/drivers/leds/leds-aw2013.c
+++ b/drivers/leds/leds-aw2013.c
@@ -397,6 +397,7 @@ static int aw2013_probe(struct i2c_client *client)
regulator_disable(chip->vcc_regulator);

error:
+ mutex_unlock(&chip->mutex);
mutex_destroy(&chip->mutex);
return ret;
}
--
2.38.4

2023-12-04 18:13:51

by Andy Shevchenko

Subject: Re: [PATCH v2 02/10] leds: aw2013: unlock mutex before destroying it

On Mon, Dec 4, 2023 at 8:07 PM George Stark <[email protected]> wrote:
>
> In the probe() callback in case of error mutex is destroyed being locked
> which is not allowed so unlock the mute before destroying.

Sounds to me like this is a real fix, hence the Fixes tag and being
first in the series.

You free to add
Reviewed-by: Andy Shevchenko <[email protected]>

--
With Best Regards,
Andy Shevchenko

2023-12-04 23:09:50

by Christophe Leroy

Subject: Re: [PATCH v2 02/10] leds: aw2013: unlock mutex before destroying it

Le 04/12/2023 à 19:05, George Stark a écrit :
> In the probe() callback in case of error mutex is destroyed being locked
> which is not allowed so unlock the mute before destroying.

Should there be a fixes: tag ? For instance on 59ea3c9faf32 ("leds: add
aw2013 driver") ?

>
> Signed-off-by: George Stark <[email protected]>
> ---
> drivers/leds/leds-aw2013.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/leds/leds-aw2013.c b/drivers/leds/leds-aw2013.c
> index 59765640b70f..c2bc0782c0cd 100644
> --- a/drivers/leds/leds-aw2013.c
> +++ b/drivers/leds/leds-aw2013.c
> @@ -397,6 +397,7 @@ static int aw2013_probe(struct i2c_client *client)
> regulator_disable(chip->vcc_regulator);
>
> error:
> + mutex_unlock(&chip->mutex);
> mutex_destroy(&chip->mutex);
> return ret;
> }

2023-12-06 08:36:50

by George Stark

Subject: Re: [PATCH v2 02/10] leds: aw2013: unlock mutex before destroying it

Hello Christophe

Thanks for the review

On 12/5/23 02:09, Christophe Leroy wrote:
>
>
> Le 04/12/2023 à 19:05, George Stark a écrit :
>> In the probe() callback in case of error mutex is destroyed being locked
>> which is not allowed so unlock the mute before destroying.
>
> Should there be a fixes: tag ? For instance on 59ea3c9faf32 ("leds: add
> aw2013 driver") ?
Ack

>
>>
>> Signed-off-by: George Stark <[email protected]>
>> ---
>> drivers/leds/leds-aw2013.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/leds/leds-aw2013.c b/drivers/leds/leds-aw2013.c
>> index 59765640b70f..c2bc0782c0cd 100644
>> --- a/drivers/leds/leds-aw2013.c
>> +++ b/drivers/leds/leds-aw2013.c
>> @@ -397,6 +397,7 @@ static int aw2013_probe(struct i2c_client *client)
>> regulator_disable(chip->vcc_regulator);
>>
>> error:
>> + mutex_unlock(&chip->mutex);
>> mutex_destroy(&chip->mutex);
>> return ret;
>> }

--
Best regards
George