2022-10-23 12:59:14

by Greg KH

[permalink] [raw]
Subject: Re: [driver-core:driver-core-testing] BUILD SUCCESS 59789f3418dd3c0a187490d49e900a59a5c8d732

On Sun, Oct 23, 2022 at 08:03:57AM +0800, kernel test robot wrote:
> tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git driver-core-testing
> branch HEAD: 59789f3418dd3c0a187490d49e900a59a5c8d732 device property: Constify parameter in device_dma_supported() and device_get_dma_attr()
>
> Unverified Warning (likely false positive, please contact us if interested):
>
> drivers/hwmon/iio_hwmon.c:155 iio_hwmon_probe() warn: could not determine type of argument 4

Andy, this is due to your changes, here's the offending code:

sname = devm_kasprintf(dev, GFP_KERNEL, "%pfwP", dev_fwnode(dev));

Now that dev_fwnode() is an inline function, the compiler is confused as
to what function to select? Maybe, I don't know, it seems odd, can you
look into it?

thanks,

greg k-h


2022-10-23 20:36:27

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [driver-core:driver-core-testing] BUILD SUCCESS 59789f3418dd3c0a187490d49e900a59a5c8d732

On Sun, Oct 23, 2022 at 02:33:40PM +0200, Greg Kroah-Hartman wrote:
> On Sun, Oct 23, 2022 at 08:03:57AM +0800, kernel test robot wrote:
> > tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git driver-core-testing
> > branch HEAD: 59789f3418dd3c0a187490d49e900a59a5c8d732 device property: Constify parameter in device_dma_supported() and device_get_dma_attr()
> >
> > Unverified Warning (likely false positive, please contact us if interested):
> >
> > drivers/hwmon/iio_hwmon.c:155 iio_hwmon_probe() warn: could not determine type of argument 4
>
> Andy, this is due to your changes, here's the offending code:
>
> sname = devm_kasprintf(dev, GFP_KERNEL, "%pfwP", dev_fwnode(dev));
>
> Now that dev_fwnode() is an inline function, the compiler is confused as
> to what function to select? Maybe, I don't know, it seems odd, can you
> look into it?

Hmm... I can't reproduce on my side.
Any (additional) information about compiler, architecture, etc?

--
With Best Regards,
Andy Shevchenko


2022-10-23 20:37:03

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [driver-core:driver-core-testing] BUILD SUCCESS 59789f3418dd3c0a187490d49e900a59a5c8d732

On Sun, Oct 23, 2022 at 10:43:07PM +0300, Andy Shevchenko wrote:
> On Sun, Oct 23, 2022 at 02:33:40PM +0200, Greg Kroah-Hartman wrote:
> > On Sun, Oct 23, 2022 at 08:03:57AM +0800, kernel test robot wrote:
> > > tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git driver-core-testing
> > > branch HEAD: 59789f3418dd3c0a187490d49e900a59a5c8d732 device property: Constify parameter in device_dma_supported() and device_get_dma_attr()
> > >
> > > Unverified Warning (likely false positive, please contact us if interested):
> > >
> > > drivers/hwmon/iio_hwmon.c:155 iio_hwmon_probe() warn: could not determine type of argument 4
> >
> > Andy, this is due to your changes, here's the offending code:
> >
> > sname = devm_kasprintf(dev, GFP_KERNEL, "%pfwP", dev_fwnode(dev));
> >
> > Now that dev_fwnode() is an inline function, the compiler is confused as
> > to what function to select? Maybe, I don't know, it seems odd, can you
> > look into it?
>
> Hmm... I can't reproduce on my side.
> Any (additional) information about compiler, architecture, etc?

I found the original report, but I don't see how to extract the defconfig /
config it used. Can you send that file to me?

--
With Best Regards,
Andy Shevchenko


2022-10-24 01:35:34

by Chen, Rong A

[permalink] [raw]
Subject: Re: [driver-core:driver-core-testing] BUILD SUCCESS 59789f3418dd3c0a187490d49e900a59a5c8d732



On 10/24/2022 3:52 AM, Andy Shevchenko wrote:
> On Sun, Oct 23, 2022 at 10:43:07PM +0300, Andy Shevchenko wrote:
>> On Sun, Oct 23, 2022 at 02:33:40PM +0200, Greg Kroah-Hartman wrote:
>>> On Sun, Oct 23, 2022 at 08:03:57AM +0800, kernel test robot wrote:
>>>> tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git driver-core-testing
>>>> branch HEAD: 59789f3418dd3c0a187490d49e900a59a5c8d732 device property: Constify parameter in device_dma_supported() and device_get_dma_attr()
>>>>
>>>> Unverified Warning (likely false positive, please contact us if interested):
>>>>
>>>> drivers/hwmon/iio_hwmon.c:155 iio_hwmon_probe() warn: could not determine type of argument 4
>>>
>>> Andy, this is due to your changes, here's the offending code:
>>>
>>> sname = devm_kasprintf(dev, GFP_KERNEL, "%pfwP", dev_fwnode(dev));
>>>
>>> Now that dev_fwnode() is an inline function, the compiler is confused as
>>> to what function to select? Maybe, I don't know, it seems odd, can you
>>> look into it?
>>
>> Hmm... I can't reproduce on my side.
>> Any (additional) information about compiler, architecture, etc?
>
> I found the original report, but I don't see how to extract the defconfig /
> config it used. Can you send that file to me?
>

Hi Andy,

The original report can be found at
https://lists.01.org/hyperkitty/list/[email protected]/thread/VE7CMY7FVIPYWHL4XMOCFWCNYTGZSTKP/

and config file can be downloaded from
https://lists.01.org/hyperkitty/list/[email protected]/message/VE7CMY7FVIPYWHL4XMOCFWCNYTGZSTKP/attachment/2/config.ksh

Best Regards,
Rong Chen

2022-10-24 09:18:43

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [driver-core:driver-core-testing] BUILD SUCCESS 59789f3418dd3c0a187490d49e900a59a5c8d732

On Mon, Oct 24, 2022 at 09:10:53AM +0800, Chen, Rong A wrote:
> On 10/24/2022 3:52 AM, Andy Shevchenko wrote:
> > On Sun, Oct 23, 2022 at 10:43:07PM +0300, Andy Shevchenko wrote:
> > > On Sun, Oct 23, 2022 at 02:33:40PM +0200, Greg Kroah-Hartman wrote:
> > > > On Sun, Oct 23, 2022 at 08:03:57AM +0800, kernel test robot wrote:
> > > > > tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git driver-core-testing
> > > > > branch HEAD: 59789f3418dd3c0a187490d49e900a59a5c8d732 device property: Constify parameter in device_dma_supported() and device_get_dma_attr()
> > > > >
> > > > > Unverified Warning (likely false positive, please contact us if interested):
> > > > >
> > > > > drivers/hwmon/iio_hwmon.c:155 iio_hwmon_probe() warn: could not determine type of argument 4
> > > >
> > > > Andy, this is due to your changes, here's the offending code:
> > > >
> > > > sname = devm_kasprintf(dev, GFP_KERNEL, "%pfwP", dev_fwnode(dev));
> > > >
> > > > Now that dev_fwnode() is an inline function, the compiler is confused as
> > > > to what function to select? Maybe, I don't know, it seems odd, can you
> > > > look into it?
> > >
> > > Hmm... I can't reproduce on my side.
> > > Any (additional) information about compiler, architecture, etc?
> >
> > I found the original report, but I don't see how to extract the defconfig /
> > config it used. Can you send that file to me?
> >
>
> Hi Andy,
>
> The original report can be found at https://lists.01.org/hyperkitty/list/[email protected]/thread/VE7CMY7FVIPYWHL4XMOCFWCNYTGZSTKP/
>
> and config file can be downloaded from https://lists.01.org/hyperkitty/list/[email protected]/message/VE7CMY7FVIPYWHL4XMOCFWCNYTGZSTKP/attachment/2/config.ksh

Thanks!

Can't reproduce on my Debian (x86_64):

gcc (Debian 12.2.0-3) 12.2.0
Copyright (C) 2022 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Is it GCC issue?

Any pointers where I can download the compiler you are using?

--
With Best Regards,
Andy Shevchenko