Hi Yoshinori, David,
On 6/22/07, Yoshinori Sato <[email protected]> wrote:
> At Tue, 12 Jun 2007 23:05:45 -0700 (PDT),
> David Miller wrote:
> >
> > From: Yoshinori Sato <[email protected]>
> > Date: Wed, 13 Jun 2007 14:59:16 +0900
> >
> > > At Tue, 12 Jun 2007 01:08:55 -0700 (PDT),
> > > David Miller wrote:
> > >
> > > > 2) It is much better to add the appropriate CONFIG_SYSCTL
> > > > ifdefs to the INET code than to force it on for everyone.
> > >
> > > It examined that, but many corrections become necessary.
> >
> > I understand, but embedded people will not be happy that
> > SYSFS is a requirement for IPV4 networking. Every little
> > bit of space savings matters for them.
>
> A reply became late, sorry.
>
> I do not check it in detail, but there seem to be part a few
> depending SYSFS.
> I need to check whether can separate a SYSFS depending part.
This thread started with SYSCTL but seems to have drifted to
SYSFS (???) for some unknown reason :-)
Anyway, INET does not need to depend upon SYSCTL.
All the code in net/ that depends on SYSCTL has already
been neatly separated out ...
Patch (tested with attached .config) below explains and resolves
the build failure. Kindly apply.
Satyam
---
[PATCH] include sysctl.h from inetdevice.h
When CONFIG_INET=y and CONFIG_SYSCTL=n:
In file included from net/core/netpoll.c:16:
include/linux/inetdevice.h:15: error:
'__NET_IPV4_CONF_MAX' undeclared here (not in a function)
make[2]: *** [net/core/netpoll.o] Error 1
make[1]: *** [net/core] Error 2
make: *** [net] Error 2
So #include sysctl.h from inetdevice.h.
Signed-off-by: Satyam Sharma <[email protected]>
---
diff -ruNp a/include/linux/inetdevice.h b/include/linux/inetdevice.h
--- a/include/linux/inetdevice.h 2007-06-23 05:15:51.000000000 +0530
+++ b/include/linux/inetdevice.h 2007-06-23 04:54:59.000000000 +0530
@@ -8,6 +8,7 @@
#include <linux/netdevice.h>
#include <linux/rcupdate.h>
#include <linux/timer.h>
+#include <linux/sysctl.h>
struct ipv4_devconf
{
From: "Satyam Sharma" <[email protected]>
Date: Sat, 23 Jun 2007 05:26:52 +0530
> [PATCH] include sysctl.h from inetdevice.h
>
> When CONFIG_INET=y and CONFIG_SYSCTL=n:
>
> In file included from net/core/netpoll.c:16:
> include/linux/inetdevice.h:15: error:
> '__NET_IPV4_CONF_MAX' undeclared here (not in a function)
> make[2]: *** [net/core/netpoll.o] Error 1
> make[1]: *** [net/core] Error 2
> make: *** [net] Error 2
>
> So #include sysctl.h from inetdevice.h.
>
> Signed-off-by: Satyam Sharma <[email protected]>
Patch applied, thank you.