2007-08-13 11:07:20

by Joe Perches

[permalink] [raw]
Subject: [PATCH] [472/2many] MAINTAINERS - TI OMAP MMC INTERFACE DRIVER

Add file pattern to MAINTAINER entry

Signed-off-by: Joe Perches <[email protected]>

diff --git a/MAINTAINERS b/MAINTAINERS
index af16a17..7a7f837 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4478,7 +4478,7 @@ F: drivers/misc/tifm*
F: drivers/mmc/host/tifm_sd.c

TI OMAP MMC INTERFACE DRIVER
-P: Carlos Aguiar, Anderson Briglia and Syed Khasim
+P: Carlos Aguiar - Anderson Briglia - Syed Khasim
M: [email protected]
W: http://linux.omap.com
W: http://www.muru.com/linux/omap/


2007-08-13 14:09:39

by Alan

[permalink] [raw]
Subject: Re: [PATCH] [472/2many] MAINTAINERS - TI OMAP MMC INTERFACE DRIVER

On Sun, 12 Aug 2007 23:37:08 -0700
[email protected] wrote:

> Add file pattern to MAINTAINER entry
>
> Signed-off-by: Joe Perches <[email protected]>
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index af16a17..7a7f837 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -4478,7 +4478,7 @@ F: drivers/misc/tifm*
> F: drivers/mmc/host/tifm_sd.c
>
> TI OMAP MMC INTERFACE DRIVER
> -P: Carlos Aguiar, Anderson Briglia and Syed Khasim
> +P: Carlos Aguiar - Anderson Briglia - Syed Khasim

NAK, Please stop sneaking other irrelevant changes into the patchset

2007-08-13 16:36:16

by Satyam Sharma

[permalink] [raw]
Subject: Re: [PATCH] [472/2many] MAINTAINERS - TI OMAP MMC INTERFACE DRIVER

On 8/13/07, Alan Cox <[email protected]> wrote:
> On Sun, 12 Aug 2007 23:37:08 -0700
> [email protected] wrote:
>
> > Add file pattern to MAINTAINER entry
> >
> > Signed-off-by: Joe Perches <[email protected]>
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index af16a17..7a7f837 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -4478,7 +4478,7 @@ F: drivers/misc/tifm*
> > F: drivers/mmc/host/tifm_sd.c
> >
> > TI OMAP MMC INTERFACE DRIVER
> > -P: Carlos Aguiar, Anderson Briglia and Syed Khasim
> > +P: Carlos Aguiar - Anderson Briglia - Syed Khasim
>
> NAK, Please stop sneaking other irrelevant changes into the patchset

Joe, it's okay to have multiple "P:" entries for the same driver/subsystem
in MAINTAINERS (grep BLACKFIN ARCHITECTURE for an extreme example :-)
So you could probably do something like that here as well (but continue
to have a single "M:" entry), though as Alan mentions it isn't really good
to make different kind of changes in the same patch.

BTW bad, sad, things happened to my mailbox while I was away :-(

Satyam

2007-08-13 16:43:21

by Satyam Sharma

[permalink] [raw]
Subject: Re: [PATCH] [472/2many] MAINTAINERS - TI OMAP MMC INTERFACE DRIVER

On 8/13/07, Satyam Sharma <[email protected]> wrote:
> On 8/13/07, Alan Cox <[email protected]> wrote:
> > On Sun, 12 Aug 2007 23:37:08 -0700
> > [email protected] wrote:
> >
> > > Add file pattern to MAINTAINER entry
> > >
> > > Signed-off-by: Joe Perches <[email protected]>
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index af16a17..7a7f837 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -4478,7 +4478,7 @@ F: drivers/misc/tifm*
> > > F: drivers/mmc/host/tifm_sd.c
> > >
> > > TI OMAP MMC INTERFACE DRIVER
> > > -P: Carlos Aguiar, Anderson Briglia and Syed Khasim
> > > +P: Carlos Aguiar - Anderson Briglia - Syed Khasim
> >
> > NAK, Please stop sneaking other irrelevant changes into the patchset
>
> Joe, it's okay to have multiple "P:" entries for the same driver/subsystem
> in MAINTAINERS (grep BLACKFIN ARCHITECTURE for an extreme example :-)
> So you could probably do something like that here as well (but continue
> to have a single "M:" entry),

Well, three maintainers listed for this driver, but the only email address
they want to give out there is:

[email protected]

which leads to:

"You are not allowed to post to this mailing list, and your message has
been automatically rejected. If you think that your messages are
being rejected in error, contact the mailing list owner at
[email protected]."

I think the real "bad patch" that should've been "NAK"ed here was the
original patch to MAINTAINERS itself that introduced this entry.


> though as Alan mentions it isn't really good
> to make different kind of changes in the same patch.
>
> BTW bad, sad, things happened to my mailbox while I was away :-(
>
> Satyam
>