2020-10-26 23:56:48

by Jaegeuk Kim

Subject: [PATCH] f2fs: call f2fs_get_meta_page_retry for nat page

When running fault injection test, if we don't stop checkpoint, some stale
NAT entries were flushed which breaks consistency.

Fixes: 86f33603f8c5 ("f2fs: handle errors of f2fs_get_meta_page_nofail")
Signed-off-by: Jaegeuk Kim <[email protected]>
---
fs/f2fs/node.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index d5d8ce077f29..42394de6c7eb 100644
--- a/fs/f2fs/node.c
+++ b/fs/f2fs/node.c
@@ -109,7 +109,7 @@ static void clear_node_page_dirty(struct page *page)

static struct page *get_current_nat_page(struct f2fs_sb_info *sbi, nid_t nid)
{
- return f2fs_get_meta_page(sbi, current_nat_addr(sbi, nid));
+ return f2fs_get_meta_page_retry(sbi, current_nat_addr(sbi, nid));
}

static struct page *get_next_nat_page(struct f2fs_sb_info *sbi, nid_t nid)
--
2.29.0.rc1.297.gfa9743e501-goog

2020-10-29 01:00:21

by Chao Yu

Subject: Re: [f2fs-dev] [PATCH] f2fs: call f2fs_get_meta_page_retry for nat page

On 2020/10/27 3:22, Jaegeuk Kim wrote:
> When running fault injection test, if we don't stop checkpoint, some stale
> NAT entries were flushed which breaks consistency.
>
> Fixes: 86f33603f8c5 ("f2fs: handle errors of f2fs_get_meta_page_nofail")
> Signed-off-by: Jaegeuk Kim <[email protected]>

Reviewed-by: Chao Yu <[email protected]>

Thanks,