LinuxLists.cc - linux-next: Fixes tag needs some work in the erofs-fixes tree

2024-03-06 21:21:19

Subject: linux-next: Fixes tag needs some work in the erofs-fixes tree

Hi all,

In commit

f531a3c17e7a ("erofs: apply proper VMA alignment for memory mapped files on THP")

Fixes tag

Fixes: be62c5198861 ("erofs: enable large folios for fscache mode")

has these problem(s):

- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'

So:

Fixes: be62c5198861 ("erofs: support large folios for fscache mode")

--
Cheers,
Stephen Rothwell

Attachments:

(No filename) (499.00 B)
OpenPGP digital signature

2024-03-07 09:18:04

by Gao Xiang

[permalink] [raw]

Subject: Re: linux-next: Fixes tag needs some work in the erofs-fixes tree

Hi,

On 2024/3/7 05:16, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> f531a3c17e7a ("erofs: apply proper VMA alignment for memory mapped files on THP")
>
> Fixes tag
>
> Fixes: be62c5198861 ("erofs: enable large folios for fscache mode")
>
> has these problem(s):
>
> - Subject does not match target commit subject
> Just use
> git log -1 --format='Fixes: %h ("%s")'
>
> So:
>
> Fixes: be62c5198861 ("erofs: support large folios for fscache mode")

Thanks for the reminder!
It seems that I quoted the wrong commit id and it should be

Fixes: e6687b89225e ("erofs: enable large folios for fscache mode")

I've fixed in the erofs-fixes tree.

Thanks,
Gao Xiang