2022-09-08 13:31:17

by wangjianli

Subject: [PATCH] i2c/busses: fix repeated words in comments

Delete the redundant word 'to'.

Signed-off-by: wangjianli <[email protected]>
---
drivers/i2c/busses/i2c-viperboard.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-viperboard.c b/drivers/i2c/busses/i2c-viperboard.c
index 8b5322c3bce0..8f87394abbcf 100644
--- a/drivers/i2c/busses/i2c-viperboard.c
+++ b/drivers/i2c/busses/i2c-viperboard.c
@@ -318,7 +318,7 @@ static int vprbrd_i2c_xfer(struct i2c_adapter *i2c, struct i2c_msg *msgs,
amsg->addr = pmsg->addr;
amsg->unknown1 = 0x00;
amsg->len = cpu_to_le16(pmsg->len);
- /* send the addr, the data goes to to board */
+ /* send the addr, the data goes to board */
ret = vprbrd_i2c_addr(vb->usb_dev, amsg);
if (ret < 0)
error = ret;
--
2.36.1

2022-09-08 14:13:43

by Peter Rosin

Subject: Re: [PATCH] i2c/busses: fix repeated words in comments

Hi!

The subject is the wrong, you are only fixing one comment and
you are only fixing one driver so you could just as well mention
that driver explicitly in the prefix with "i2c: viperboard: ...".

2022-09-08 at 15:21, wangjianli wrote:
> Delete the redundant word 'to'.
>
> Signed-off-by: wangjianli <[email protected]>
> ---
> drivers/i2c/busses/i2c-viperboard.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-viperboard.c b/drivers/i2c/busses/i2c-viperboard.c
> index 8b5322c3bce0..8f87394abbcf 100644
> --- a/drivers/i2c/busses/i2c-viperboard.c
> +++ b/drivers/i2c/busses/i2c-viperboard.c
> @@ -318,7 +318,7 @@ static int vprbrd_i2c_xfer(struct i2c_adapter *i2c, struct i2c_msg *msgs,
> amsg->addr = pmsg->addr;
> amsg->unknown1 = 0x00;
> amsg->len = cpu_to_le16(pmsg->len);
> - /* send the addr, the data goes to to board */
> + /* send the addr, the data goes to board */

I'd change it to "goes to the board" instead.

Cheers,
Peter

> ret = vprbrd_i2c_addr(vb->usb_dev, amsg);
> if (ret < 0)
> error = ret;