On 2022-09-30 02:38, Dong Chenchen wrote:
> Kernel test robot throws below warning ->
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn31/dcn31_hpo_dp_stream_encoder.c:
> In function 'dcn31_hpo_dp_stream_enc_update_dp_info_packets':
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn31/dcn31_hpo_dp_stream_encoder.c:439:14:
> warning: variable 'sdp_stream_enable' set but not used
> [-Wunused-but-set-variable]
> 439 | bool sdp_stream_enable = false;
>
> Removed unused variable 'sdp_stream_enable'.
>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Dong Chenchen <[email protected]>
> ---
> .../dc/dcn31/dcn31_hpo_dp_stream_encoder.c | 16 ++++++----------
> 1 file changed, 6 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_hpo_dp_stream_encoder.c b/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_hpo_dp_stream_encoder.c
> index 23621ff08c90..7daafbab98da 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_hpo_dp_stream_encoder.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_hpo_dp_stream_encoder.c
> @@ -436,32 +436,28 @@ static void dcn31_hpo_dp_stream_enc_update_dp_info_packets(
> {
> struct dcn31_hpo_dp_stream_encoder *enc3 = DCN3_1_HPO_DP_STREAM_ENC_FROM_HPO_STREAM_ENC(enc);
> uint32_t dmdata_packet_enabled = 0;
> - bool sdp_stream_enable = false;
>
> - if (info_frame->vsc.valid) {
> + if (info_frame->vsc.valid)
> enc->vpg->funcs->update_generic_info_packet(
> enc->vpg,
> 0, /* packetIndex */
> &info_frame->vsc,
> true);
> - sdp_stream_enable = true;
> - }
> - if (info_frame->spd.valid) {
> +
> + if (info_frame->spd.valid)
> enc->vpg->funcs->update_generic_info_packet(
> enc->vpg,
> 2, /* packetIndex */
> &info_frame->spd,
> true);
> - sdp_stream_enable = true;
> - }
> - if (info_frame->hdrsmd.valid) {
> +
> + if (info_frame->hdrsmd.valid)
> enc->vpg->funcs->update_generic_info_packet(
> enc->vpg,
> 3, /* packetIndex */
> &info_frame->hdrsmd,
> true);
> - sdp_stream_enable = true;
> - }
> +
> /* enable/disable transmission of packet(s).
> * If enabled, packet transmission begins on the next frame
> */
Thanks a lot for your patch,
Reviewed-by: Rodrigo Siqueira <[email protected]>
and applied to amd-staging-drm-next.
Thanks
Siqueira