2022-12-22 19:29:50

by Stefan Wahren

[permalink] [raw]
Subject: Re: [PATCH v2 0/4] staging: vchiq: Rework child platform device (un)register

Hi Umang,

Am 22.12.22 um 20:14 schrieb Umang Jain:
> V2 series for addressing the TODO item:
> "Get rid of all non essential global structures and create a proper
> per device structure"
> This series:
> - Fixes a platform device leak (1/4)
> - Simplifies vchiq_register_child (2/4 and 3/4)
> - drops global references for child platform devices and prepares for
> addition of new child devices in future (4/4)

the whole problem i see with this series is that kernel module support
is broken. So i'm not able to test everything.

Did you did just test driver removable?

>
> v1: https://lore.kernel.org/all/[email protected]/
>
> Umang Jain (4):
> staging: vc04_services: Stop leaking platform device on error path
> staging: vchiq: Do not assign default dma_mask explicitly
> staging: vchiq: Simplify platform devices registration
> staging: vchiq: Rework child platform device (un)register
>
> .../interface/vchiq_arm/vchiq_arm.c | 40 ++++++++++---------
> 1 file changed, 21 insertions(+), 19 deletions(-)
>