2016-10-11 23:49:48

by Brian Masney

[permalink] [raw]
Subject: [PATCH] ideapad-laptop: Add Lenovo Yoga 910-13IKB to no_hw_rfkill dmi list

The Lenovo Yoga 910-13IKB does not have a hw rfkill switch, and trying
to read the hw rfkill switch through the ideapad module causes it to
always report as blocked.

This commit adds the Lenovo Yoga 910-13IKB to the no_hw_rfkill dmi list,
fixing the WiFI breakage.

Signed-off-by: Brian Masney <[email protected]>
---
drivers/platform/x86/ideapad-laptop.c | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
index d1a091b..a232394 100644
--- a/drivers/platform/x86/ideapad-laptop.c
+++ b/drivers/platform/x86/ideapad-laptop.c
@@ -933,6 +933,13 @@ static const struct dmi_system_id no_hw_rfkill_list[] = {
DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo YOGA 900"),
},
},
+ {
+ .ident = "Lenovo YOGA 910-13IKB",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+ DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo YOGA 910-13IKB"),
+ },
+ },
{}
};

--
2.7.4


2016-10-12 08:17:55

by Darren Hart

[permalink] [raw]
Subject: Re: [PATCH] ideapad-laptop: Add Lenovo Yoga 910-13IKB to no_hw_rfkill dmi list

On Tue, Oct 11, 2016 at 07:28:02PM -0400, Brian Masney wrote:
> The Lenovo Yoga 910-13IKB does not have a hw rfkill switch, and trying
> to read the hw rfkill switch through the ideapad module causes it to
> always report as blocked.
>
> This commit adds the Lenovo Yoga 910-13IKB to the no_hw_rfkill dmi list,
> fixing the WiFI breakage.
>
> Signed-off-by: Brian Masney <[email protected]>

Thanks Brian,

Queued to testing.

--
Darren Hart
Intel Open Source Technology Center

2016-10-20 00:59:01

by Ike Panhc

[permalink] [raw]
Subject: Re: [PATCH] ideapad-laptop: Add Lenovo Yoga 910-13IKB to no_hw_rfkill dmi list

On 10/12/2016 04:17 PM, Darren Hart wrote:
> On Tue, Oct 11, 2016 at 07:28:02PM -0400, Brian Masney wrote:
>> The Lenovo Yoga 910-13IKB does not have a hw rfkill switch, and trying
>> to read the hw rfkill switch through the ideapad module causes it to
>> always report as blocked.
>>
>> This commit adds the Lenovo Yoga 910-13IKB to the no_hw_rfkill dmi list,
>> fixing the WiFI breakage.
>>
>> Signed-off-by: Brian Masney <[email protected]>
>
> Thanks Brian,
>
> Queued to testing.
>

Hi Brian,

Could you post output of acpidump and `cat /sys/class/dmi/id/modalias` for record please?

I would like to see if there is anyway to short the growing blacklist.

Thanks a lot.

--
Ike Panhc

2016-10-20 01:18:18

by Brian Masney

[permalink] [raw]
Subject: Re: [PATCH] ideapad-laptop: Add Lenovo Yoga 910-13IKB to no_hw_rfkill dmi list

On Thu, Oct 20, 2016 at 08:58:53AM +0800, Ike Panhc wrote:
> On 10/12/2016 04:17 PM, Darren Hart wrote:
> > On Tue, Oct 11, 2016 at 07:28:02PM -0400, Brian Masney wrote:
> >> The Lenovo Yoga 910-13IKB does not have a hw rfkill switch, and trying
> >> to read the hw rfkill switch through the ideapad module causes it to
> >> always report as blocked.
> >>
> >> This commit adds the Lenovo Yoga 910-13IKB to the no_hw_rfkill dmi list,
> >> fixing the WiFI breakage.
> >>
> >> Signed-off-by: Brian Masney <[email protected]>
> >
> > Thanks Brian,
> >
> > Queued to testing.
> >
>
> Hi Brian,
>
> Could you post output of acpidump and `cat /sys/class/dmi/id/modalias` for record please?
>
> I would like to see if there is anyway to short the growing blacklist.

Hi Ike,
I attached the compressed output from acpidump. Here is the contents
of my /sys/class/dmi/id/modalias:

dmi:bvnLENOVO:bvr2JCN28WW:bd09/09/2016:svnLENOVO:pn80VF:pvrLenovoYOGA910-13IKB:rvnLENOVO:rnVIUU4:rvrSDK0J40709WIN:cvnLENOVO:ct10:cvrLenovoYOGA910-13IKB:

Let me know if you need anything else.

Brian


Attachments:
(No filename) (1.06 kB)
lenovo-yoga-910-acpidump.txt.bz2 (208.36 kB)
Download all attachments

2016-10-20 15:46:21

by Mika Westerberg

[permalink] [raw]
Subject: Re: [PATCH] ideapad-laptop: Add Lenovo Yoga 910-13IKB to no_hw_rfkill dmi list

On Wed, Oct 19, 2016 at 09:18:14PM -0400, Brian Masney wrote:
> On Thu, Oct 20, 2016 at 08:58:53AM +0800, Ike Panhc wrote:
> > On 10/12/2016 04:17 PM, Darren Hart wrote:
> > > On Tue, Oct 11, 2016 at 07:28:02PM -0400, Brian Masney wrote:
> > >> The Lenovo Yoga 910-13IKB does not have a hw rfkill switch, and trying
> > >> to read the hw rfkill switch through the ideapad module causes it to
> > >> always report as blocked.
> > >>
> > >> This commit adds the Lenovo Yoga 910-13IKB to the no_hw_rfkill dmi list,
> > >> fixing the WiFI breakage.
> > >>
> > >> Signed-off-by: Brian Masney <[email protected]>
> > >
> > > Thanks Brian,
> > >
> > > Queued to testing.
> > >
> >
> > Hi Brian,
> >
> > Could you post output of acpidump and `cat /sys/class/dmi/id/modalias` for record please?
> >
> > I would like to see if there is anyway to short the growing blacklist.
>
> Hi Ike,
> I attached the compressed output from acpidump. Here is the contents
> of my /sys/class/dmi/id/modalias:
>
> dmi:bvnLENOVO:bvr2JCN28WW:bd09/09/2016:svnLENOVO:pn80VF:pvrLenovoYOGA910-13IKB:rvnLENOVO:rnVIUU4:rvrSDK0J40709WIN:cvnLENOVO:ct10:cvrLenovoYOGA910-13IKB:

Hmm, comparing that to my Yoga 900:

dmi:bvnLENOVO:bvr2JCN28WW:bd09/09/2016:svnLENOVO:pn80VF:pvrLenovoYOGA910-13IKB:rvnLENOVO:rnVIUU4:rvrSDK0J40709WIN:cvnLENOVO:ct10:cvrLenovoYOGA910-13IKB:
dmi:bvnLENOVO:bvrC6CN37WW:bd03/01/2016:svnLENOVO:pnINVALID:pvrINVALID:rvnLENOVO:rnVIUU4:rvrSDK0K17763WIN:cvnLENOVO:ct10:cvrINVALID:

The DMI_BOARD_NAME==VIIU4 seems to be in both (I hope it is limited to
only such Lenovo Yoga laptops without physical rfkill switch ;-))