2018-01-24 19:56:04

by SF Markus Elfring

Subject: [PATCH 0/2] Input-appletouch: Adjustments for two function implementations

From: Markus Elfring <[email protected]>
Date: Wed, 24 Jan 2018 20:50:20 +0100

Two update suggestions were taken into account
from static source code analysis.

Markus Elfring (2):
Delete an error message for a failed memory allocation in atp_geyser_init()
Improve a size determination in atp_probe()

drivers/input/mouse/appletouch.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

--
2.16.1

2018-01-24 19:57:03

by SF Markus Elfring

Subject: [PATCH 1/2] Input: appletouch: Delete an error message for a failed memory allocation in atp_geyser_init()

From: Markus Elfring <[email protected]>
Date: Wed, 24 Jan 2018 20:40:54 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/input/mouse/appletouch.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/input/mouse/appletouch.c b/drivers/input/mouse/appletouch.c
index 81a695d0b4e0..3a709d21ea93 100644
--- a/drivers/input/mouse/appletouch.c
+++ b/drivers/input/mouse/appletouch.c
@@ -280,10 +280,8 @@ static int atp_geyser_init(struct atp *dev)
int ret;

data = kmalloc(8, GFP_KERNEL);
- if (!data) {
- dev_err(&dev->intf->dev, "Out of memory\n");
+ if (!data)
return -ENOMEM;
- }

size = usb_control_msg(udev, usb_rcvctrlpipe(udev, 0),
ATP_GEYSER_MODE_READ_REQUEST_ID,
--
2.16.1