2024-03-07 02:22:02

by Vignesh Raman

[permalink] [raw]
Subject: [PATCH v3] drm/ci: update device type for volteer devices

Volteer devices in the collabora lab are categorized under the
asus-cx9400-volteer device type. The majority of these units
has an Intel Core i5-1130G7 CPU, while some of them have a
Intel Core i7-1160G7 CPU instead. So due to this difference,
new device type template is added for the Intel Core i5-1130G7
and i7-1160G7 variants of the Acer Chromebook Spin 514 (CP514-2H)
volteer Chromebooks. So update the same in drm-ci.

https://gitlab.collabora.com/lava/lava/-/merge_requests/149

Fixes: 0119c894ab0d ("drm: Add initial ci/ subdirectory")
Reviewed-by: David Heidelberg <[email protected]>
Signed-off-by: Vignesh Raman <[email protected]>
---

v2:
- Add fixes tag so change gets propagated to stable.
https://gitlab.freedesktop.org/vigneshraman/linux/-/pipelines/1119672

v3:
- Fix checkpatch warning.
Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")'

---
drivers/gpu/drm/ci/test.yml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/ci/test.yml b/drivers/gpu/drm/ci/test.yml
index 0857773e5c5f..8bc63912fddb 100644
--- a/drivers/gpu/drm/ci/test.yml
+++ b/drivers/gpu/drm/ci/test.yml
@@ -252,11 +252,11 @@ i915:cml:
i915:tgl:
extends:
- .i915
- parallel: 8
+ parallel: 5
variables:
- DEVICE_TYPE: asus-cx9400-volteer
+ DEVICE_TYPE: acer-cp514-2h-1130g7-volteer
GPU_VERSION: tgl
- RUNNER_TAG: mesa-ci-x86-64-lava-asus-cx9400-volteer
+ RUNNER_TAG: mesa-ci-x86-64-lava-acer-cp514-2h-1130g7-volteer

.amdgpu:
extends:
--
2.40.1



2024-03-07 13:21:45

by Helen Koike

[permalink] [raw]
Subject: Re: [PATCH v3] drm/ci: update device type for volteer devices



On 06/03/2024 23:18, Vignesh Raman wrote:
> Volteer devices in the collabora lab are categorized under the
> asus-cx9400-volteer device type. The majority of these units
> has an Intel Core i5-1130G7 CPU, while some of them have a
> Intel Core i7-1160G7 CPU instead. So due to this difference,
> new device type template is added for the Intel Core i5-1130G7
> and i7-1160G7 variants of the Acer Chromebook Spin 514 (CP514-2H)
> volteer Chromebooks. So update the same in drm-ci.
>
> https://gitlab.collabora.com/lava/lava/-/merge_requests/149
>
> Fixes: 0119c894ab0d ("drm: Add initial ci/ subdirectory")
> Reviewed-by: David Heidelberg <[email protected]>
> Signed-off-by: Vignesh Raman <[email protected]>

Acked-by: Helen Koike <[email protected]>

Thanks
Helen

> ---
>
> v2:
> - Add fixes tag so change gets propagated to stable.
> https://gitlab.freedesktop.org/vigneshraman/linux/-/pipelines/1119672
>
> v3:
> - Fix checkpatch warning.
> Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")'
>
> ---
> drivers/gpu/drm/ci/test.yml | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/ci/test.yml b/drivers/gpu/drm/ci/test.yml
> index 0857773e5c5f..8bc63912fddb 100644
> --- a/drivers/gpu/drm/ci/test.yml
> +++ b/drivers/gpu/drm/ci/test.yml
> @@ -252,11 +252,11 @@ i915:cml:
> i915:tgl:
> extends:
> - .i915
> - parallel: 8
> + parallel: 5
> variables:
> - DEVICE_TYPE: asus-cx9400-volteer
> + DEVICE_TYPE: acer-cp514-2h-1130g7-volteer
> GPU_VERSION: tgl
> - RUNNER_TAG: mesa-ci-x86-64-lava-asus-cx9400-volteer
> + RUNNER_TAG: mesa-ci-x86-64-lava-acer-cp514-2h-1130g7-volteer
>
> .amdgpu:
> extends:

2024-03-07 14:38:31

by Helen Koike

[permalink] [raw]
Subject: Re: [PATCH v3] drm/ci: update device type for volteer devices



On 07/03/2024 10:21, Helen Koike wrote:
>
>
> On 06/03/2024 23:18, Vignesh Raman wrote:
>> Volteer devices in the collabora lab are categorized under the
>> asus-cx9400-volteer device type. The majority of these units
>> has an Intel Core i5-1130G7 CPU, while some of them have a
>> Intel Core i7-1160G7 CPU instead. So due to this difference,
>> new device type template is added for the Intel Core i5-1130G7
>> and i7-1160G7 variants of the Acer Chromebook Spin 514 (CP514-2H)
>> volteer Chromebooks. So update the same in drm-ci.
>>
>> https://gitlab.collabora.com/lava/lava/-/merge_requests/149
>>
>> Fixes: 0119c894ab0d ("drm: Add initial ci/ subdirectory")
>> Reviewed-by: David Heidelberg <[email protected]>
>> Signed-off-by: Vignesh Raman <[email protected]>
>
> Acked-by: Helen Koike <[email protected]>

Applied to drm-misc-next.

>
> Thanks
> Helen
>
>> ---
>>
>> v2:
>>    - Add fixes tag so change gets propagated to stable.
>>
>> https://gitlab.freedesktop.org/vigneshraman/linux/-/pipelines/1119672
>>
>> v3:
>>    - Fix checkpatch warning.
>>      Please use correct Fixes: style 'Fixes: <12 chars of sha1>
>> ("<title line>")'
>>
>> ---
>>   drivers/gpu/drm/ci/test.yml | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/ci/test.yml b/drivers/gpu/drm/ci/test.yml
>> index 0857773e5c5f..8bc63912fddb 100644
>> --- a/drivers/gpu/drm/ci/test.yml
>> +++ b/drivers/gpu/drm/ci/test.yml
>> @@ -252,11 +252,11 @@ i915:cml:
>>   i915:tgl:
>>     extends:
>>       - .i915
>> -  parallel: 8
>> +  parallel: 5
>>     variables:
>> -    DEVICE_TYPE: asus-cx9400-volteer
>> +    DEVICE_TYPE: acer-cp514-2h-1130g7-volteer
>>       GPU_VERSION: tgl
>> -    RUNNER_TAG: mesa-ci-x86-64-lava-asus-cx9400-volteer
>> +    RUNNER_TAG: mesa-ci-x86-64-lava-acer-cp514-2h-1130g7-volteer
>>   .amdgpu:
>>     extends: