2018-01-13 11:48:44

by SF Markus Elfring

Subject: [PATCH] pinctrl: sprd: Use seq_putc() in sprd_pinconf_group_dbg_show()

From: Markus Elfring <[email protected]>
Date: Sat, 13 Jan 2018 12:42:14 +0100

A single character (line break) should be put into a sequence.
Thus use the corresponding function "seq_putc".

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/pinctrl/sprd/pinctrl-sprd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/sprd/pinctrl-sprd.c b/drivers/pinctrl/sprd/pinctrl-sprd.c
index 63529911445c..ba1c2ca406e4 100644
--- a/drivers/pinctrl/sprd/pinctrl-sprd.c
+++ b/drivers/pinctrl/sprd/pinctrl-sprd.c
@@ -818,7 +818,7 @@ static void sprd_pinconf_group_dbg_show(struct pinctrl_dev *pctldev,

grp = &info->groups[selector];

- seq_printf(s, "\n");
+ seq_putc(s, '\n');
for (i = 0; i < grp->npins; i++, config++) {
unsigned int pin_id = grp->pins[i];

--
2.15.1

2018-01-16 10:08:51

by Linus Walleij

Subject: Re: [PATCH] pinctrl: sprd: Use seq_putc() in sprd_pinconf_group_dbg_show()

On Sat, Jan 13, 2018 at 12:48 PM, SF Markus Elfring
<[email protected]> wrote:

> From: Markus Elfring <[email protected]>
> Date: Sat, 13 Jan 2018 12:42:14 +0100
>
> A single character (line break) should be put into a sequence.
> Thus use the corresponding function "seq_putc".
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <[email protected]>

Patch applied.

Yours,
Linus Walleij