2022-10-08 06:36:20

by Jiapeng Chong

Subject: [PATCH 1/3] AppArmor: Fix kernel-doc

security/apparmor/audit.c:93: warning: expecting prototype for audit_base(). Prototype was for audit_pre() instead.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2339
Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
security/apparmor/audit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/apparmor/audit.c b/security/apparmor/audit.c
index 8dfdda98fbf1..5a7978aa4b19 100644
--- a/security/apparmor/audit.c
+++ b/security/apparmor/audit.c
@@ -83,7 +83,7 @@ static const char *const aa_class_names[] = {
*/

/**
- * audit_base - core AppArmor function.
+ * audit_pre() - core AppArmor function.
* @ab: audit buffer to fill (NOT NULL)
* @ca: audit structure containing data to audit (NOT NULL)
*
--
2.20.1.7.g153144c

2022-10-08 06:37:05

by Jiapeng Chong

Subject: [PATCH 2/3] LSM: Fix kernel-doc

security/apparmor/lsm.c:753: warning: expecting prototype for apparmor_bprm_committed_cred(). Prototype was for apparmor_bprm_committed_creds() instead.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2338
Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
security/apparmor/lsm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/apparmor/lsm.c b/security/apparmor/lsm.c
index cc83cbf2ce20..c56afd1307c1 100644
--- a/security/apparmor/lsm.c
+++ b/security/apparmor/lsm.c
@@ -746,7 +746,7 @@ static void apparmor_bprm_committing_creds(struct linux_binprm *bprm)
}

/**
- * apparmor_bprm_committed_cred - do cleanup after new creds committed
+ * apparmor_bprm_committed_creds() - do cleanup after new creds committed
* @bprm: binprm for the exec (NOT NULL)
*/
static void apparmor_bprm_committed_creds(struct linux_binprm *bprm)
--
2.20.1.7.g153144c

2022-10-08 06:39:57

by Jiapeng Chong

Subject: [PATCH 3/3] AppArmor: Fix kernel-doc

security/apparmor/ipc.c:53: warning: expecting prototype for audit_cb(). Prototype was for audit_signal_cb() instead.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2337
Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
security/apparmor/ipc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/apparmor/ipc.c b/security/apparmor/ipc.c
index 1d4099385bdf..5acde746775f 100644
--- a/security/apparmor/ipc.c
+++ b/security/apparmor/ipc.c
@@ -45,7 +45,7 @@ static const char *audit_signal_mask(u32 mask)
}

/**
- * audit_cb - call back for signal specific audit fields
+ * audit_signal_cb() - call back for signal specific audit fields
* @ab: audit_buffer (NOT NULL)
* @va: audit struct to audit values of (NOT NULL)
*/
--
2.20.1.7.g153144c

2022-10-11 02:30:45

by John Johansen

Subject: Re: [PATCH 1/3] AppArmor: Fix kernel-doc

On 10/7/22 23:34, Jiapeng Chong wrote:
> security/apparmor/audit.c:93: warning: expecting prototype for audit_base(). Prototype was for audit_pre() instead.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2339
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>

Acked-by: John Johansen <[email protected]>

I have pulled this into my tree

> ---
> security/apparmor/audit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/apparmor/audit.c b/security/apparmor/audit.c
> index 8dfdda98fbf1..5a7978aa4b19 100644
> --- a/security/apparmor/audit.c
> +++ b/security/apparmor/audit.c
> @@ -83,7 +83,7 @@ static const char *const aa_class_names[] = {
> */
>
> /**
> - * audit_base - core AppArmor function.
> + * audit_pre() - core AppArmor function.
> * @ab: audit buffer to fill (NOT NULL)
> * @ca: audit structure containing data to audit (NOT NULL)
> *

2022-10-11 02:30:57

by John Johansen

Subject: Re: [PATCH 3/3] AppArmor: Fix kernel-doc

On 10/7/22 23:34, Jiapeng Chong wrote:
> security/apparmor/ipc.c:53: warning: expecting prototype for audit_cb(). Prototype was for audit_signal_cb() instead.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2337
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>

Acked-by: John Johansen <[email protected]>

I have pulled this into my tree

> ---
> security/apparmor/ipc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/apparmor/ipc.c b/security/apparmor/ipc.c
> index 1d4099385bdf..5acde746775f 100644
> --- a/security/apparmor/ipc.c
> +++ b/security/apparmor/ipc.c
> @@ -45,7 +45,7 @@ static const char *audit_signal_mask(u32 mask)
> }
>
> /**
> - * audit_cb - call back for signal specific audit fields
> + * audit_signal_cb() - call back for signal specific audit fields
> * @ab: audit_buffer (NOT NULL)
> * @va: audit struct to audit values of (NOT NULL)
> */

2022-10-11 02:33:44

by John Johansen

Subject: Re: [PATCH 2/3] LSM: Fix kernel-doc

On 10/7/22 23:34, Jiapeng Chong wrote:
> security/apparmor/lsm.c:753: warning: expecting prototype for apparmor_bprm_committed_cred(). Prototype was for apparmor_bprm_committed_creds() instead.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2338
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>

Acked-by: John Johansen <[email protected]>

I have pulled this into my tree

> ---
> security/apparmor/lsm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/apparmor/lsm.c b/security/apparmor/lsm.c
> index cc83cbf2ce20..c56afd1307c1 100644
> --- a/security/apparmor/lsm.c
> +++ b/security/apparmor/lsm.c
> @@ -746,7 +746,7 @@ static void apparmor_bprm_committing_creds(struct linux_binprm *bprm)
> }
>
> /**
> - * apparmor_bprm_committed_cred - do cleanup after new creds committed
> + * apparmor_bprm_committed_creds() - do cleanup after new creds committed
> * @bprm: binprm for the exec (NOT NULL)
> */
> static void apparmor_bprm_committed_creds(struct linux_binprm *bprm)