2023-08-08 22:50:15

by srinivas pandruvada

Subject: [PATCH] platform/x86: ISST: Reduce noise for missing numa information in logs

On platforms with no numa support and with several CPUs, logs have lots
of noise for message "Fail to get numa node for CPU:.."

Change pr_info() to pr_info_once() as one print is enough to show the
issue.

Signed-off-by: Srinivas Pandruvada <[email protected]>
---
drivers/platform/x86/intel/speed_select_if/isst_if_common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/platform/x86/intel/speed_select_if/isst_if_common.c b/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
index 1f59ac55c5f7..a95004e3d80b 100644
--- a/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
+++ b/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
@@ -335,8 +335,8 @@ static struct pci_dev *_isst_if_get_pci_dev(int cpu, int bus_no, int dev, int fn

node = dev_to_node(&_pci_dev->dev);
if (node == NUMA_NO_NODE) {
- pr_info("Fail to get numa node for CPU:%d bus:%d dev:%d fn:%d\n",
- cpu, bus_no, dev, fn);
+ pr_info_once("Fail to get numa node for CPU:%d bus:%d dev:%d fn:%d\n",
+ cpu, bus_no, dev, fn);
continue;
}

--
2.41.0

2023-08-09 20:25:48

by Hans de Goede

Subject: Re: [PATCH] platform/x86: ISST: Reduce noise for missing numa information in logs

Hi,

On 8/8/23 19:43, Srinivas Pandruvada wrote:
> On platforms with no numa support and with several CPUs, logs have lots
> of noise for message "Fail to get numa node for CPU:.."
>
> Change pr_info() to pr_info_once() as one print is enough to show the
> issue.
>
> Signed-off-by: Srinivas Pandruvada <[email protected]>

Thank you for your patch, I've applied this patch to my fixes
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=fixes

Note it will show up in my fixes branch once I've pushed my
local branch there, which might take a while.

I will include this patch in my next fixes pull-req to Linus
for the current kernel development cycle.

Regards,

Hans



> ---
> drivers/platform/x86/intel/speed_select_if/isst_if_common.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/intel/speed_select_if/isst_if_common.c b/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
> index 1f59ac55c5f7..a95004e3d80b 100644
> --- a/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
> +++ b/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
> @@ -335,8 +335,8 @@ static struct pci_dev *_isst_if_get_pci_dev(int cpu, int bus_no, int dev, int fn
>
> node = dev_to_node(&_pci_dev->dev);
> if (node == NUMA_NO_NODE) {
> - pr_info("Fail to get numa node for CPU:%d bus:%d dev:%d fn:%d\n",
> - cpu, bus_no, dev, fn);
> + pr_info_once("Fail to get numa node for CPU:%d bus:%d dev:%d fn:%d\n",
> + cpu, bus_no, dev, fn);
> continue;
> }
>