2022-12-28 22:08:56

by Johan Jonker

[permalink] [raw]
Subject: [PATCH v1 1/2] dt-bindings: phy: rockchip: convert rockchip-dp-phy.txt to yaml

Convert rockchip-dp-phy.txt to yaml.

Changed:
rename file name

Signed-off-by: Johan Jonker <[email protected]>
---
.../bindings/phy/rockchip,dp-phy.yaml | 41 +++++++++++++++++++
.../bindings/phy/rockchip-dp-phy.txt | 26 ------------
2 files changed, 41 insertions(+), 26 deletions(-)
create mode 100644 Documentation/devicetree/bindings/phy/rockchip,dp-phy.yaml
delete mode 100644 Documentation/devicetree/bindings/phy/rockchip-dp-phy.txt

diff --git a/Documentation/devicetree/bindings/phy/rockchip,dp-phy.yaml b/Documentation/devicetree/bindings/phy/rockchip,dp-phy.yaml
new file mode 100644
index 000000000..73f75ab1c
--- /dev/null
+++ b/Documentation/devicetree/bindings/phy/rockchip,dp-phy.yaml
@@ -0,0 +1,41 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/phy/rockchip,dp-phy.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Rockchip specific extensions to the Analogix Display Port PHY
+
+maintainers:
+ - Heiko Stuebner <[email protected]>
+
+properties:
+ compatible:
+ const: rockchip,rk3288-dp-phy
+
+ clocks:
+ maxItems: 1
+
+ clock-names:
+ const: 24m
+
+ "#phy-cells":
+ const: 0
+
+required:
+ - compatible
+ - clocks
+ - clock-names
+ - "#phy-cells"
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/rk3288-cru.h>
+ edp-phy {
+ compatible = "rockchip,rk3288-dp-phy";
+ clocks = <&cru SCLK_EDP_24M>;
+ clock-names = "24m";
+ #phy-cells = <0>;
+ };
diff --git a/Documentation/devicetree/bindings/phy/rockchip-dp-phy.txt b/Documentation/devicetree/bindings/phy/rockchip-dp-phy.txt
deleted file mode 100644
index e3b4809fb..000000000
--- a/Documentation/devicetree/bindings/phy/rockchip-dp-phy.txt
+++ /dev/null
@@ -1,26 +0,0 @@
-Rockchip specific extensions to the Analogix Display Port PHY
-------------------------------------
-
-Required properties:
-- compatible : should be one of the following supported values:
- - "rockchip.rk3288-dp-phy"
-- clocks: from common clock binding: handle to dp clock.
- of memory mapped region.
-- clock-names: from common clock binding:
- Required elements: "24m"
-- #phy-cells : from the generic PHY bindings, must be 0;
-
-Example:
-
-grf: syscon@ff770000 {
- compatible = "rockchip,rk3288-grf", "syscon", "simple-mfd";
-
-...
-
- edp_phy: edp-phy {
- compatible = "rockchip,rk3288-dp-phy";
- clocks = <&cru SCLK_EDP_24M>;
- clock-names = "24m";
- #phy-cells = <0>;
- };
-};
--
2.20.1


2022-12-28 22:08:58

by Johan Jonker

[permalink] [raw]
Subject: [PATCH v1 2/2] dt-bindings: soc: rockchip: graf: add rockchip,dp-phy.yaml

Add new converted rockchip,dp-phy.yaml to grf.yaml file.

Signed-off-by: Johan Jonker <[email protected]>
---
Documentation/devicetree/bindings/soc/rockchip/grf.yaml | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
index 7ac9aa5fa..36f6d85a9 100644
--- a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
+++ b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
@@ -96,8 +96,11 @@ allOf:
then:
properties:
edp-phy:
- description:
- Documentation/devicetree/bindings/phy/rockchip-dp-phy.txt
+ type: object
+
+ $ref: /schemas/phy/rockchip,dp-phy.yaml#
+
+ unevaluatedProperties: false

- if:
properties:
--
2.20.1

2022-12-29 08:54:41

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v1 2/2] dt-bindings: soc: rockchip: graf: add rockchip,dp-phy.yaml

On 28/12/2022 23:02, Johan Jonker wrote:
> Add new converted rockchip,dp-phy.yaml to grf.yaml file.
>
> Signed-off-by: Johan Jonker <[email protected]>
> ---
> Documentation/devicetree/bindings/soc/rockchip/grf.yaml | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
> index 7ac9aa5fa..36f6d85a9 100644
> --- a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
> +++ b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
> @@ -96,8 +96,11 @@ allOf:
> then:
> properties:
> edp-phy:
> - description:
> - Documentation/devicetree/bindings/phy/rockchip-dp-phy.txt
> + type: object
> +

Drop the blank line

> + $ref: /schemas/phy/rockchip,dp-phy.yaml#
> +

Ditto, so with updated path:

Acked-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2022-12-29 08:56:49

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v1 1/2] dt-bindings: phy: rockchip: convert rockchip-dp-phy.txt to yaml

On 28/12/2022 23:01, Johan Jonker wrote:
> Convert rockchip-dp-phy.txt to yaml.
>
> Changed:
> rename file name
>
> Signed-off-by: Johan Jonker <[email protected]>
> ---
> .../bindings/phy/rockchip,dp-phy.yaml | 41 +++++++++++++++++++
> .../bindings/phy/rockchip-dp-phy.txt | 26 ------------
> 2 files changed, 41 insertions(+), 26 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/phy/rockchip,dp-phy.yaml
> delete mode 100644 Documentation/devicetree/bindings/phy/rockchip-dp-phy.txt
>
> diff --git a/Documentation/devicetree/bindings/phy/rockchip,dp-phy.yaml b/Documentation/devicetree/bindings/phy/rockchip,dp-phy.yaml
> new file mode 100644
> index 000000000..73f75ab1c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/rockchip,dp-phy.yaml
> @@ -0,0 +1,41 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/phy/rockchip,dp-phy.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Rockchip specific extensions to the Analogix Display Port PHY
> +
> +maintainers:
> + - Heiko Stuebner <[email protected]>
> +
> +properties:
> + compatible:
> + const: rockchip,rk3288-dp-phy

No new compatibles were added here for the last 7 years, so it is safe
to assume none will appear in the future. Use the compatible as filename.

Best regards,
Krzysztof