This patch series modify the vme_user driver's place in
menuconfig (1/3), fixes a missing `depends on` line in a Kconfig file
(2/3), and rearrages the directory tree for the driver allowing a more
straightforward comprehension of its contents (3/3).
Signed-off-by: Bruno Moreira-Guedes <[email protected]>
Bruno Moreira-Guedes (3):
staging: vme: Adjusted VME_USER in Kconfig
staging: vme: Fix missing `depends on` at KConfig
staging: vme: "drivers/staging/vme" tree cleanup
MAINTAINERS | 2 +-
drivers/staging/Kconfig | 2 ++
drivers/staging/Makefile | 2 +-
drivers/staging/vme/Makefile | 2 --
drivers/staging/{vme/devices => vme_user}/Kconfig | 2 +-
drivers/staging/{vme/devices => vme_user}/Makefile | 0
drivers/staging/{vme/devices => vme_user}/vme_user.c | 0
drivers/staging/{vme/devices => vme_user}/vme_user.h | 0
drivers/vme/Kconfig | 2 --
9 files changed, 5 insertions(+), 7 deletions(-)
delete mode 100644 drivers/staging/vme/Makefile
rename drivers/staging/{vme/devices => vme_user}/Kconfig (93%)
rename drivers/staging/{vme/devices => vme_user}/Makefile (100%)
rename drivers/staging/{vme/devices => vme_user}/vme_user.c (100%)
rename drivers/staging/{vme/devices => vme_user}/vme_user.h (100%)
--
2.35.1
On Tue, Apr 12, 2022 at 03:53:46AM -0300, Bruno Moreira-Guedes wrote:
> This patch series modify the vme_user driver's place in
> menuconfig (1/3), fixes a missing `depends on` line in a Kconfig file
> (2/3), and rearrages the directory tree for the driver allowing a more
> straightforward comprehension of its contents (3/3).
For a patchset it (typically) is OK to put the changelog in the
cover letter. See the first patch tutorial for how to format that.
That give you a little less editing to do for each individual patch.
I do see that you responded to this cover letter with clarifications.
That is fine. Just be aware that it will probably stop reviewers from
continuing their review, because you've already alerted them a v3 is
in the works. I'm going to go ahead and comment on a few format things
in this set, so maybe you can tidy them up in v3.
Alison
>
> Signed-off-by: Bruno Moreira-Guedes <[email protected]>
>
> Bruno Moreira-Guedes (3):
> staging: vme: Adjusted VME_USER in Kconfig
> staging: vme: Fix missing `depends on` at KConfig
> staging: vme: "drivers/staging/vme" tree cleanup
>
> MAINTAINERS | 2 +-
> drivers/staging/Kconfig | 2 ++
> drivers/staging/Makefile | 2 +-
> drivers/staging/vme/Makefile | 2 --
> drivers/staging/{vme/devices => vme_user}/Kconfig | 2 +-
> drivers/staging/{vme/devices => vme_user}/Makefile | 0
> drivers/staging/{vme/devices => vme_user}/vme_user.c | 0
> drivers/staging/{vme/devices => vme_user}/vme_user.h | 0
> drivers/vme/Kconfig | 2 --
> 9 files changed, 5 insertions(+), 7 deletions(-)
> delete mode 100644 drivers/staging/vme/Makefile
> rename drivers/staging/{vme/devices => vme_user}/Kconfig (93%)
> rename drivers/staging/{vme/devices => vme_user}/Makefile (100%)
> rename drivers/staging/{vme/devices => vme_user}/vme_user.c (100%)
> rename drivers/staging/{vme/devices => vme_user}/vme_user.h (100%)
>
> --
> 2.35.1
>
Originally, the KConfig file for VME_USER
("drivers/staging/vme/devices/Kconfig") was sourced at
"drivers/vme/boards/KConfig". It misses a `depends on` line for VME_BUS,
which went unnoticeable for a menuconfig user who wouldn't be able to
select it through this interface without selecting the CONFIG_VME_BUS
option because it was nested on its menu.
A patch to move appropriately this driver to the "Staging" submenu[1],
however, unveiled this missing `depends on` line, since it moved the
`source` line for VME_USER's KConfig to somewhere else, allowing it to
be compiled without the support for VME_BRIDGE. While it compiles fine
and seems to initialize the driver fine[2], it seems to make no sense
having VME_USER without VME_BUS.
This patches addresses it by adding the VME_BUS to the `depends on` line
at "drivers/staging/vme/devices/Kconfig".
CHANGELOG:
v2:
- Added this patch to the patchset
REFERENCES AND NOTES
[1] First commit in this patch, originally submitted at
https://lore.kernel.org/linux-staging/[email protected]/T/#t
[2] Tested both as module and as built-in.
Signed-off-by: Bruno Moreira-Guedes <[email protected]>
---
drivers/staging/vme/devices/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vme/devices/Kconfig b/drivers/staging/vme/devices/Kconfig
index 5651bb16b28b..e8b4461bf27f 100644
--- a/drivers/staging/vme/devices/Kconfig
+++ b/drivers/staging/vme/devices/Kconfig
@@ -3,7 +3,7 @@ comment "VME Device Drivers"
config VME_USER
tristate "VME user space access driver"
- depends on STAGING
+ depends on STAGING && VME_BUS
help
If you say Y here you want to be able to access a limited number of
VME windows in a manner at least semi-compatible with the interface
--
2.35.1