2019-08-09 08:44:28

by Yue Haibing

[permalink] [raw]
Subject: [PATCH -next] afs: remove unused variable 'afs_zero_fid'

fs/afs/fsclient.c:18:29: warning:
afs_zero_fid defined but not used [-Wunused-const-variable=]

It is never used since commit 025db80c9e42 ("afs: Trace
the initiation and completion of client calls")

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: YueHaibing <[email protected]>
---
fs/afs/fsclient.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/fs/afs/fsclient.c b/fs/afs/fsclient.c
index 114f281..67af068 100644
--- a/fs/afs/fsclient.c
+++ b/fs/afs/fsclient.c
@@ -15,8 +15,6 @@
#include "xdr_fs.h"
#include "protocol_yfs.h"

-static const struct afs_fid afs_zero_fid;
-
static inline void afs_use_fs_server(struct afs_call *call, struct afs_cb_interest *cbi)
{
call->cbi = afs_get_cb_interest(cbi);
--
2.7.4



2019-08-09 17:46:14

by Jeffrey Altman

[permalink] [raw]
Subject: Re: [PATCH -next] afs: remove unused variable 'afs_zero_fid'

Confirmed.

On 8/9/2019 4:42 AM, YueHaibing wrote:
> fs/afs/fsclient.c:18:29: warning:
> afs_zero_fid defined but not used [-Wunused-const-variable=]
>
> It is never used since commit 025db80c9e42 ("afs: Trace
> the initiation and completion of client calls")
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> fs/afs/fsclient.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/afs/fsclient.c b/fs/afs/fsclient.c
> index 114f281..67af068 100644
> --- a/fs/afs/fsclient.c
> +++ b/fs/afs/fsclient.c
> @@ -15,8 +15,6 @@
> #include "xdr_fs.h"
> #include "protocol_yfs.h"
>
> -static const struct afs_fid afs_zero_fid;
> -
> static inline void afs_use_fs_server(struct afs_call *call, struct afs_cb_interest *cbi)
> {
> call->cbi = afs_get_cb_interest(cbi);
>


Attachments:
jaltman.vcf (283.00 B)
smime.p7s (3.94 kB)
S/MIME Cryptographic Signature
Download all attachments