2023-10-22 08:56:43

by Jan Kiszka

Subject: [PATCH] net: ti: icssg-prueth: Add phys_port_name support

From: Jan Kiszka <[email protected]>

Helps identifying the ports in udev rules e.g.

Signed-off-by: Jan Kiszka <[email protected]>
---

Seems such logic was lost during the upstream rewrite of the SDK
version.

drivers/net/ethernet/ti/icssg/icssg_prueth.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)

diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.c b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
index 4914d0ef58e9..ffae89a6ccc5 100644
--- a/drivers/net/ethernet/ti/icssg/icssg_prueth.c
+++ b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
@@ -1653,6 +1653,19 @@ static void emac_ndo_get_stats64(struct net_device *ndev,
stats->tx_dropped = ndev->stats.tx_dropped;
}

+static int emac_ndo_get_phys_port_name(struct net_device *ndev, char *name,
+ size_t len)
+{
+ struct prueth_emac *emac = netdev_priv(ndev);
+ int ret;
+
+ ret = snprintf(name, len, "p%d", emac->port_id);
+ if (ret >= len)
+ return -EINVAL;
+
+ return 0;
+}
+
static const struct net_device_ops emac_netdev_ops = {
.ndo_open = emac_ndo_open,
.ndo_stop = emac_ndo_stop,
@@ -1663,6 +1676,7 @@ static const struct net_device_ops emac_netdev_ops = {
.ndo_set_rx_mode = emac_ndo_set_rx_mode,
.ndo_eth_ioctl = emac_ndo_ioctl,
.ndo_get_stats64 = emac_ndo_get_stats64,
+ .ndo_get_phys_port_name = emac_ndo_get_phys_port_name,
};

/* get emac_port corresponding to eth_node name */
--
2.35.3

2023-10-24 00:11:49

by Jacob Keller

Subject: Re: [PATCH] net: ti: icssg-prueth: Add phys_port_name support

On 10/22/2023 1:56 AM, Jan Kiszka wrote:
> From: Jan Kiszka <[email protected]>
>
> Helps identifying the ports in udev rules e.g.
>
> Signed-off-by: Jan Kiszka <[email protected]>
> ---
>
> Seems such logic was lost during the upstream rewrite of the SDK
> version.
>

Reviewed-by: Jacob Keller <[email protected]>

2023-10-24 08:41:29

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] net: ti: icssg-prueth: Add phys_port_name support

Hello:

This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <[email protected]>:

On Sun, 22 Oct 2023 10:56:22 +0200 you wrote:
> From: Jan Kiszka <[email protected]>
>
> Helps identifying the ports in udev rules e.g.
>
> Signed-off-by: Jan Kiszka <[email protected]>
> ---
>
> [...]

Here is the summary with links:
- net: ti: icssg-prueth: Add phys_port_name support
https://git.kernel.org/netdev/net-next/c/f6e12277011d

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html