As the initial value of the return variable result is never used, it can
be removed.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta <[email protected]>
---
drivers/staging/ks7010/ks7010_sdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
index 74551eb717fc..4b379542ecd5 100644
--- a/drivers/staging/ks7010/ks7010_sdio.c
+++ b/drivers/staging/ks7010/ks7010_sdio.c
@@ -380,7 +380,7 @@ int ks_wlan_hw_tx(struct ks_wlan_private *priv, void *p, unsigned long size,
struct sk_buff *skb),
struct sk_buff *skb)
{
- int result = 0;
+ int result;
struct hostif_hdr *hdr;
hdr = (struct hostif_hdr *)p;
--
2.19.1
On Fri, May 24, 2019 at 11:26:02AM +0530, Nishka Dasgupta wrote:
> As the initial value of the return variable result is never used, it can
> be removed.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta <[email protected]>
> ---
> drivers/staging/ks7010/ks7010_sdio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Didn't you already send this?
And please run a spell-checker on your subject line when you resend
this :)
thanks,
greg k-h
On 24/05/19 12:22 PM, Greg KH wrote:
> On Fri, May 24, 2019 at 11:26:02AM +0530, Nishka Dasgupta wrote:
>> As the initial value of the return variable result is never used, it can
>> be removed.
>> Issue found with Coccinelle.
>>
>> Signed-off-by: Nishka Dasgupta <[email protected]>
>> ---
>> drivers/staging/ks7010/ks7010_sdio.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Didn't you already send this?
I sent two patches about removing initialisation in ks7010 today, but I
couldn't make it a patch series because the different files had
different maintainers. I don't think I've sent this patch before, but
it's possible I made a mistake because my local tree has not been the
best organised lately. I apologise for the confusion.
> And please run a spell-checker on your subject line when you resend
> this :)
Is this about "initialise" (and now also "organised", "apologise", etc)?
As far as I'm aware whether the word ends in "-ise"/"-ize" depends on
local varieties of English, so I went with the variety I'm more used to.
Should I stick with American/Canadian spelling variants (including "-or"
over "-our" etc) from now on?
Nishka
>
> thanks,
>
> greg k-h
>
On Fri, May 24, 2019 at 12:31:19PM +0530, Nishka Dasgupta wrote:
> On 24/05/19 12:22 PM, Greg KH wrote:
> > On Fri, May 24, 2019 at 11:26:02AM +0530, Nishka Dasgupta wrote:
> > > As the initial value of the return variable result is never used, it can
> > > be removed.
> > > Issue found with Coccinelle.
> > >
> > > Signed-off-by: Nishka Dasgupta <[email protected]>
> > > ---
> > > drivers/staging/ks7010/ks7010_sdio.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Didn't you already send this?
>
> I sent two patches about removing initialisation in ks7010 today, but I
> couldn't make it a patch series because the different files had different
> maintainers. I don't think I've sent this patch before, but it's possible I
> made a mistake because my local tree has not been the best organised lately.
> I apologise for the confusion.
>
I saw two patches with the same subject line, if I messed up, please
resend.
> > And please run a spell-checker on your subject line when you resend
> > this :)
>
> Is this about "initialise" (and now also "organised", "apologise", etc)? As
> far as I'm aware whether the word ends in "-ise"/"-ize" depends on local
> varieties of English, so I went with the variety I'm more used to. Should I
> stick with American/Canadian spelling variants (including "-or" over "-our"
> etc) from now on?
Ah, didn't realize that was a valid spelling, sorry.
greg k-h