2023-12-19 16:14:38

by Piro Yang

Subject: [PATCH V3 RESEND] staging:vme_user:Fix the issue of return the wrong error code

Fixed the issue of returning the -ENOSYS error code when an
error occurs.

The error code of -ENOSYS indicates Invalid system call number,
but there is not system call error. So replace -ENOSYS error code
by using -EINVAL error code to return.

Signed-off-by: Piro Yang <[email protected]>
---
v3: change the description and format for the patch.

v2: split two different changes,
only fix the issue of wrong error code.
---
drivers/staging/vme_user/vme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vme_user/vme.c b/drivers/staging/vme_user/vme.c
index 5c416c31ec57..9bc2d35405af 100644
--- a/drivers/staging/vme_user/vme.c
+++ b/drivers/staging/vme_user/vme.c
@@ -341,7 +341,7 @@ int vme_slave_set(struct vme_resource *resource, int enabled,

if (!bridge->slave_set) {
dev_err(bridge->parent, "Function not supported\n");
- return -ENOSYS;
+ return -EINVAL;
}

if (!(((image->address_attr & aspace) == aspace) &&
--
2.25.1

2023-12-19 16:25:38

by Julia Lawall

Subject: Re: [PATCH V3 RESEND] staging:vme_user:Fix the issue of return the wrong error code

The subject line looks wrong. Normally there are spaces after :. Look at
what others have done on this file and do the same.

Also, did you previously send a V3? Resend is only for when you are
sending exactly the same thing you sent previously, not because you fixed
something up.

On Wed, 20 Dec 2023, Piro Yang wrote:

> Fixed the issue of returning the -ENOSYS error code when an
> error occurs.
>
> The error code of -ENOSYS indicates Invalid system call number,
> but there is not system call error. So replace -ENOSYS error code
> by using -EINVAL error code to return.
>
> Signed-off-by: Piro Yang <[email protected]>
> ---
> v3: change the description and format for the patch.
>
> v2: split two different changes,
> only fix the issue of wrong error code.
> ---

The second --- is not needed.

Finally, it's not the application period of Outreachy, so please don't use
the list [email protected]. That's only for outreachy applicants.

thanks,
julia

> drivers/staging/vme_user/vme.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vme_user/vme.c b/drivers/staging/vme_user/vme.c
> index 5c416c31ec57..9bc2d35405af 100644
> --- a/drivers/staging/vme_user/vme.c
> +++ b/drivers/staging/vme_user/vme.c
> @@ -341,7 +341,7 @@ int vme_slave_set(struct vme_resource *resource, int enabled,
>
> if (!bridge->slave_set) {
> dev_err(bridge->parent, "Function not supported\n");
> - return -ENOSYS;
> + return -EINVAL;
> }
>
> if (!(((image->address_attr & aspace) == aspace) &&
> --
> 2.25.1
>
>
>