2024-03-11 17:11:51

by Muhammad Usama Anjum

Subject: Re: [PATCH] wifi: mt76: connac: check for null before dereferencing

Soft reminder

On 3/1/24 7:44 PM, Muhammad Usama Anjum wrote:
> The wcid can be NULL. It should be checked for validity before
> dereferencing it to avoid crash.
>
> Fixes: 098428c400ff ("wifi: mt76: connac: set correct muar_idx for mt799x chipsets")
> Signed-off-by: Muhammad Usama Anjum <[email protected]>
> ---
> drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c
> index af0c2b2aacb00..7af60eebe517a 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c
> @@ -283,7 +283,7 @@ __mt76_connac_mcu_alloc_sta_req(struct mt76_dev *dev, struct mt76_vif *mvif,
> };
> struct sk_buff *skb;
>
> - if (is_mt799x(dev) && !wcid->sta)
> + if (is_mt799x(dev) && wcid && !wcid->sta)
> hdr.muar_idx = 0xe;
>
> mt76_connac_mcu_get_wlan_idx(dev, wcid, &hdr.wlan_idx_lo,

--
BR,
Muhammad Usama Anjum

2024-04-04 11:50:21

by Muhammad Usama Anjum

Subject: Re: [PATCH] wifi: mt76: connac: check for null before dereferencing

Soft reminder

On 3/11/24 10:11 PM, Muhammad Usama Anjum wrote:
> Soft reminder
>
> On 3/1/24 7:44 PM, Muhammad Usama Anjum wrote:
>> The wcid can be NULL. It should be checked for validity before
>> dereferencing it to avoid crash.
>>
>> Fixes: 098428c400ff ("wifi: mt76: connac: set correct muar_idx for mt799x chipsets")
>> Signed-off-by: Muhammad Usama Anjum <[email protected]>
>> ---
>> drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c
>> index af0c2b2aacb00..7af60eebe517a 100644
>> --- a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c
>> +++ b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c
>> @@ -283,7 +283,7 @@ __mt76_connac_mcu_alloc_sta_req(struct mt76_dev *dev, struct mt76_vif *mvif,
>> };
>> struct sk_buff *skb;
>>
>> - if (is_mt799x(dev) && !wcid->sta)
>> + if (is_mt799x(dev) && wcid && !wcid->sta)
>> hdr.muar_idx = 0xe;
>>
>> mt76_connac_mcu_get_wlan_idx(dev, wcid, &hdr.wlan_idx_lo,
>

--
BR,
Muhammad Usama Anjum