2023-04-17 12:41:21

by Pin-yen Lin

[permalink] [raw]
Subject: [PATCH] arm64: dts: mt8173: Power on panel regulator on boot

Add "regulator-boot-on" to "panel_fixed_3v3" to save time on powering
the regulator during boot. Also add "off-on-delay-us" to the node to
make sure the regulator never violates the panel timing requirements.

Signed-off-by: Pin-yen Lin <[email protected]>

---

arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
index d77f6af19065..03d1ab2ca820 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
@@ -96,6 +96,8 @@ panel_fixed_3v3: regulator1 {
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
enable-active-high;
+ regulator-boot-on;
+ off-on-delay-us = <500000>;
gpio = <&pio 41 GPIO_ACTIVE_HIGH>;
pinctrl-names = "default";
pinctrl-0 = <&panel_fixed_pins>;
--
2.40.0.634.g4ca3ef3211-goog


2023-04-17 13:35:40

by Doug Anderson

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: mt8173: Power on panel regulator on boot

Hi,

On Mon, Apr 17, 2023 at 5:40 AM Pin-yen Lin <[email protected]> wrote:
>
> Add "regulator-boot-on" to "panel_fixed_3v3" to save time on powering
> the regulator during boot. Also add "off-on-delay-us" to the node to
> make sure the regulator never violates the panel timing requirements.
>
> Signed-off-by: Pin-yen Lin <[email protected]>
>
> ---
>
> arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 2 ++
> 1 file changed, 2 insertions(+)

Reviewed-by: Douglas Anderson <[email protected]>

2023-05-26 06:26:10

by Pin-yen Lin

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: mt8173: Power on panel regulator on boot

Friendly ping on this patch.

Pin-yen

On Mon, Apr 17, 2023 at 9:32 PM Doug Anderson <[email protected]> wrote:
>
> Hi,
>
> On Mon, Apr 17, 2023 at 5:40 AM Pin-yen Lin <[email protected]> wrote:
> >
> > Add "regulator-boot-on" to "panel_fixed_3v3" to save time on powering
> > the regulator during boot. Also add "off-on-delay-us" to the node to
> > make sure the regulator never violates the panel timing requirements.
> >
> > Signed-off-by: Pin-yen Lin <[email protected]>
> >
> > ---
> >
> > arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 2 ++
> > 1 file changed, 2 insertions(+)
>
> Reviewed-by: Douglas Anderson <[email protected]>

2023-05-29 16:28:29

by Matthias Brugger

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: mt8173: Power on panel regulator on boot



On 17/04/2023 14:39, Pin-yen Lin wrote:
> Add "regulator-boot-on" to "panel_fixed_3v3" to save time on powering
> the regulator during boot. Also add "off-on-delay-us" to the node to
> make sure the regulator never violates the panel timing requirements.
>
> Signed-off-by: Pin-yen Lin <[email protected]>
>

Applied, thanks!

> ---
>
> arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> index d77f6af19065..03d1ab2ca820 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> @@ -96,6 +96,8 @@ panel_fixed_3v3: regulator1 {
> regulator-min-microvolt = <3300000>;
> regulator-max-microvolt = <3300000>;
> enable-active-high;
> + regulator-boot-on;
> + off-on-delay-us = <500000>;
> gpio = <&pio 41 GPIO_ACTIVE_HIGH>;
> pinctrl-names = "default";
> pinctrl-0 = <&panel_fixed_pins>;