2020-01-21 03:38:29

by Alex Shi

Subject: [PATCH] OCFS2: use OCFS2_SEC_BITS in macro

This macros should be used as it.

Signed-off-by: Alex Shi <[email protected]>
Cc: Mark Fasheh <[email protected]>
Cc: Joel Becker <[email protected]>
Cc: Joseph Qi <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
fs/ocfs2/dlmglue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c
index cda1027d0819..0d6daf49b72a 100644
--- a/fs/ocfs2/dlmglue.c
+++ b/fs/ocfs2/dlmglue.c
@@ -2133,7 +2133,7 @@ static void ocfs2_downconvert_on_unlock(struct ocfs2_super *osb,
}

#define OCFS2_SEC_BITS 34
-#define OCFS2_SEC_SHIFT (64 - 34)
+#define OCFS2_SEC_SHIFT (64 - OCFS2_SEC_BITS)
#define OCFS2_NSEC_MASK ((1ULL << OCFS2_SEC_SHIFT) - 1)

/* LVB only has room for 64 bits of time here so we pack it for
--
1.8.3.1

2020-01-26 01:48:14

by Joseph Qi

Subject: Re: [PATCH] OCFS2: use OCFS2_SEC_BITS in macro

On 20/1/21 11:37, Alex Shi wrote:
> This macros should be used as it.
>
> Signed-off-by: Alex Shi <[email protected]>
> Cc: Mark Fasheh <[email protected]>
> Cc: Joel Becker <[email protected]>
> Cc: Joseph Qi <[email protected]>
> Cc: [email protected]
> Cc: [email protected]

Acked-by: Joseph Qi <[email protected]>
> ---
> fs/ocfs2/dlmglue.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c
> index cda1027d0819..0d6daf49b72a 100644
> --- a/fs/ocfs2/dlmglue.c
> +++ b/fs/ocfs2/dlmglue.c
> @@ -2133,7 +2133,7 @@ static void ocfs2_downconvert_on_unlock(struct ocfs2_super *osb,
> }
>
> #define OCFS2_SEC_BITS 34
> -#define OCFS2_SEC_SHIFT (64 - 34)
> +#define OCFS2_SEC_SHIFT (64 - OCFS2_SEC_BITS)
> #define OCFS2_NSEC_MASK ((1ULL << OCFS2_SEC_SHIFT) - 1)
>
> /* LVB only has room for 64 bits of time here so we pack it for
>