2021-10-06 20:57:35

by rkardell

Subject: [PATCH] media: dvb: Solve problem with Terratec cinergyT2 when removed and reconnected, or after sleep.

Module used count is incremented 1 time but decremented 2 times by
dvb_frontend.
This patch inhibit module used count to go to -1.


Signed-off-by: rkl099 <[email protected]>
---
?drivers/media/usb/dvb-usb/cinergyT2-core.c | 1 +
?1 file changed, 1 insertion(+)

diff --git a/drivers/media/usb/dvb-usb/cinergyT2-core.c
b/drivers/media/usb/dvb-usb/cinergyT2-core.c
index 23f1093d2..56f58b3f9 100644
--- a/drivers/media/usb/dvb-usb/cinergyT2-core.c
+++ b/drivers/media/usb/dvb-usb/cinergyT2-core.c
@@ -69,6 +69,7 @@ static int cinergyt2_frontend_attach(struct
dvb_usb_adapter *adap)
???? struct cinergyt2_state *st = d->priv;
???? int ret;

+??? try_module_get(THIS_MODULE);
???? adap->fe_adap[0].fe = cinergyt2_fe_attach(adap->dev);

???? mutex_lock(&d->data_mutex);
--
2.30.2

2021-11-19 16:19:20

by Mauro Carvalho Chehab

Subject: Re: [PATCH] media: dvb: Solve problem with Terratec cinergyT2 when removed and reconnected, or after sleep.

Em Wed, 6 Oct 2021 22:39:29 +0200
rkardell <[email protected]> escreveu:

> Module used count is incremented 1 time but decremented 2 times by
> dvb_frontend.
> This patch inhibit module used count to go to -1.

Same problems of your previous patch:

- utf8 "\xA0" does not map to Unicode
- your SoB/From doesn't contain your name.

>
>
> Signed-off-by: rkl099 <[email protected]>
> ---
>  drivers/media/usb/dvb-usb/cinergyT2-core.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/usb/dvb-usb/cinergyT2-core.c
> b/drivers/media/usb/dvb-usb/cinergyT2-core.c
> index 23f1093d2..56f58b3f9 100644
> --- a/drivers/media/usb/dvb-usb/cinergyT2-core.c
> +++ b/drivers/media/usb/dvb-usb/cinergyT2-core.c
> @@ -69,6 +69,7 @@ static int cinergyt2_frontend_attach(struct
> dvb_usb_adapter *adap)
>      struct cinergyt2_state *st = d->priv;
>      int ret;
>
> +    try_module_get(THIS_MODULE);
>      adap->fe_adap[0].fe = cinergyt2_fe_attach(adap->dev);
>
>      mutex_lock(&d->data_mutex);