Hi Santosh,
This series fixes mdio and dss status nodes from "ok" to "okay"
As per Device Tree Specification [1], the status parameter of nodes can
be "okay", "disabled", etc. "ok" is not a valid parameter.
U-boot Driver Model does not recognize status="ok" either and treats
the node as disabled.
[1] https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.3
cheers,
-roger
Roger Quadros (2):
ARM: dts: keystone-k2*-evm: Fix mdio node status to "okay"
ARM: dts: keystone-k2g-evm: Fix dss node status to "okay"
arch/arm/boot/dts/keystone-k2e-evm.dts | 2 +-
arch/arm/boot/dts/keystone-k2g-evm.dts | 2 +-
arch/arm/boot/dts/keystone-k2hk-evm.dts | 2 +-
arch/arm/boot/dts/keystone-k2l-evm.dts | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
--
2.17.1
As per Device Tree Specification [1], the status parameter of nodes can
be "okay", "disabled", etc. "ok" is not a valid parameter.
U-boot Driver Model does not recognize status="ok" either and treats
the node as disabled.
[1] https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.3
Signed-off-by: Roger Quadros <[email protected]>
---
arch/arm/boot/dts/keystone-k2g-evm.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/keystone-k2g-evm.dts b/arch/arm/boot/dts/keystone-k2g-evm.dts
index d800f26b6275..57680323e202 100644
--- a/arch/arm/boot/dts/keystone-k2g-evm.dts
+++ b/arch/arm/boot/dts/keystone-k2g-evm.dts
@@ -534,7 +534,7 @@
&dss {
pinctrl-names = "default";
pinctrl-0 = <&vout_pins>;
- status = "ok";
+ status = "okay";
port {
dpi_out: endpoint {
--
2.17.1
As per Device Tree Specification [1], the status parameter of nodes can
be "okay", "disabled", etc. "ok" is not a valid parameter.
U-boot Driver Model does not recognize status="ok" either and treats
the node as disabled.
[1] https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.3
Cc: Grygorii Strashko <[email protected]>
Signed-off-by: Roger Quadros <[email protected]>
---
arch/arm/boot/dts/keystone-k2e-evm.dts | 2 +-
arch/arm/boot/dts/keystone-k2hk-evm.dts | 2 +-
arch/arm/boot/dts/keystone-k2l-evm.dts | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/keystone-k2e-evm.dts b/arch/arm/boot/dts/keystone-k2e-evm.dts
index 66fec5f5d081..acac242ebdf7 100644
--- a/arch/arm/boot/dts/keystone-k2e-evm.dts
+++ b/arch/arm/boot/dts/keystone-k2e-evm.dts
@@ -159,7 +159,7 @@
};
&mdio {
- status = "ok";
+ status = "okay";
ethphy0: ethernet-phy@0 {
compatible = "marvell,88E1514", "marvell,88E1510", "ethernet-phy-ieee802.3-c22";
reg = <0>;
diff --git a/arch/arm/boot/dts/keystone-k2hk-evm.dts b/arch/arm/boot/dts/keystone-k2hk-evm.dts
index ad4e22afe133..5e85f000acc3 100644
--- a/arch/arm/boot/dts/keystone-k2hk-evm.dts
+++ b/arch/arm/boot/dts/keystone-k2hk-evm.dts
@@ -183,7 +183,7 @@
};
&mdio {
- status = "ok";
+ status = "okay";
ethphy0: ethernet-phy@0 {
compatible = "marvell,88E1111", "ethernet-phy-ieee802.3-c22";
reg = <0>;
diff --git a/arch/arm/boot/dts/keystone-k2l-evm.dts b/arch/arm/boot/dts/keystone-k2l-evm.dts
index e200533d26a4..a6cbff4cfe20 100644
--- a/arch/arm/boot/dts/keystone-k2l-evm.dts
+++ b/arch/arm/boot/dts/keystone-k2l-evm.dts
@@ -132,7 +132,7 @@
};
&mdio {
- status = "ok";
+ status = "okay";
ethphy0: ethernet-phy@0 {
compatible = "marvell,88E1514", "marvell,88E1510", "ethernet-phy-ieee802.3-c22";
reg = <0>;
--
2.17.1
On 24/08/2021 13:58, Roger Quadros wrote:
> Hi Santosh,
>
> This series fixes mdio and dss status nodes from "ok" to "okay"
>
> As per Device Tree Specification [1], the status parameter of nodes can
> be "okay", "disabled", etc. "ok" is not a valid parameter.
>
> U-boot Driver Model does not recognize status="ok" either and treats
> the node as disabled.
>
> [1] https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.3
>
> cheers,
> -roger
>
> Roger Quadros (2):
> ARM: dts: keystone-k2*-evm: Fix mdio node status to "okay"
> ARM: dts: keystone-k2g-evm: Fix dss node status to "okay"
>
> arch/arm/boot/dts/keystone-k2e-evm.dts | 2 +-
> arch/arm/boot/dts/keystone-k2g-evm.dts | 2 +-
> arch/arm/boot/dts/keystone-k2hk-evm.dts | 2 +-
> arch/arm/boot/dts/keystone-k2l-evm.dts | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
Changes in this version:
- updated commit message to point to DT spec instead of schema.
On 13:58-20210824, Roger Quadros wrote:
> Hi Santosh,
>
> This series fixes mdio and dss status nodes from "ok" to "okay"
>
> As per Device Tree Specification [1], the status parameter of nodes can
> be "okay", "disabled", etc. "ok" is not a valid parameter.
>
> U-boot Driver Model does not recognize status="ok" either and treats
> the node as disabled.
^^ I suspect the above comment in the patches is to indicate side effect
of non-compliance.
>
> [1] https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.3
>
> cheers,
> -roger
>
> Roger Quadros (2):
> ARM: dts: keystone-k2*-evm: Fix mdio node status to "okay"
> ARM: dts: keystone-k2g-evm: Fix dss node status to "okay"
Reviewed-by: Nishanth Menon <[email protected]>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
On 24/08/2021 13:58, Roger Quadros wrote:
> As per Device Tree Specification [1], the status parameter of nodes can
> be "okay", "disabled", etc. "ok" is not a valid parameter.
>
> U-boot Driver Model does not recognize status="ok" either and treats
> the node as disabled.
>
> [1] https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.3
>
> Cc: Grygorii Strashko <[email protected]>
> Signed-off-by: Roger Quadros <[email protected]>
> ---
> arch/arm/boot/dts/keystone-k2e-evm.dts | 2 +-
> arch/arm/boot/dts/keystone-k2hk-evm.dts | 2 +-
> arch/arm/boot/dts/keystone-k2l-evm.dts | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
Thank you.
Reviewed-by: Grygorii Strashko <[email protected]>
--
Best regards,
grygorii
Hi Santosh
On 24/08/2021 13:58, Roger Quadros wrote:
> Hi Santosh,
>
> This series fixes mdio and dss status nodes from "ok" to "okay"
>
> As per Device Tree Specification [1], the status parameter of nodes can
> be "okay", "disabled", etc. "ok" is not a valid parameter.
>
> U-boot Driver Model does not recognize status="ok" either and treats
> the node as disabled.
>
> [1] https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.3
Could you please queue these trivial fixes for 5.15? Thanks
>
> cheers,
> -roger
>
> Roger Quadros (2):
> ARM: dts: keystone-k2*-evm: Fix mdio node status to "okay"
> ARM: dts: keystone-k2g-evm: Fix dss node status to "okay"
>
> arch/arm/boot/dts/keystone-k2e-evm.dts | 2 +-
> arch/arm/boot/dts/keystone-k2g-evm.dts | 2 +-
> arch/arm/boot/dts/keystone-k2hk-evm.dts | 2 +-
> arch/arm/boot/dts/keystone-k2l-evm.dts | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
cheers,
-roger
Hi Santosh
On 25/08/2021 19:17, Nishanth Menon wrote:
> On 13:58-20210824, Roger Quadros wrote:
>> Hi Santosh,
>>
>> This series fixes mdio and dss status nodes from "ok" to "okay"
>>
>> As per Device Tree Specification [1], the status parameter of nodes can
>> be "okay", "disabled", etc. "ok" is not a valid parameter.
>>
>> U-boot Driver Model does not recognize status="ok" either and treats
>> the node as disabled.
>
> ^^ I suspect the above comment in the patches is to indicate side effect
> of non-compliance.
>
>>
>> [1] https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.3
>>
>> cheers,
>> -roger
>>
>> Roger Quadros (2):
>> ARM: dts: keystone-k2*-evm: Fix mdio node status to "okay"
>> ARM: dts: keystone-k2g-evm: Fix dss node status to "okay"
>
>
> Reviewed-by: Nishanth Menon <[email protected]>
>
Is there a chance to still pull these in for -next? Thanks.
cheers,
-roger