2023-03-20 16:18:29

by Mirsad Todorovac

[permalink] [raw]
Subject: BUG: selftests/net/tls: FAIL in sm4_ccm tests

Hi all,

I don't know if this is expected result, so I am filing the bug report.

Reports like this from tools/testing/selftests/net/tls:

# RUN tls.13_sm4_ccm.sendfile ...
# tls.c:323:sendfile:Expected ret (-1) == 0 (0)
# sendfile: Test terminated by assertion
# FAIL tls.13_sm4_ccm.sendfile
not ok 251 tls.13_sm4_ccm.sendfile
# RUN tls.13_sm4_ccm.send_then_sendfile ...
# tls.c:323:send_then_sendfile:Expected ret (-1) == 0 (0)
# send_then_sendfile: Test terminated by assertion
# FAIL tls.13_sm4_ccm.send_then_sendfile
not ok 252 tls.13_sm4_ccm.send_then_sendfile
# RUN tls.13_sm4_ccm.multi_chunk_sendfile ...
# tls.c:323:multi_chunk_sendfile:Expected ret (-1) == 0 (0)
# multi_chunk_sendfile: Test terminated by assertion
# FAIL tls.13_sm4_ccm.multi_chunk_sendfile
not ok 253 tls.13_sm4_ccm.multi_chunk_sendfile

Apparently, all are connected with sm4 hash ccm.

(Please find the complete report attached in tls-6.3-rc3-1.log)

The rest of the failed tests is as follows from this command:

[marvin@pc-mtodorov linux_torvalds]$ grep -v '^#' ../kselftest-6.3-rc3-1.log | grep "not ok"
not ok 2 selftests: alsa: pcm-test # TIMEOUT 45 seconds
not ok 1 selftests: drivers/net/bonding: bond-arp-interval-causes-panic.sh # exit=1
not ok 2 selftests: drivers/net/bonding: bond-break-lacpdu-tx.sh # exit=1
not ok 1 selftests: filesystems/binderfs: binderfs_test # exit=1
not ok 1 selftests: ftrace: ftracetest # exit=1
not ok 1 selftests: gpio: gpio-mockup.sh # exit=1
not ok 1 selftests: intel_pstate: run.sh # TIMEOUT 45 seconds
not ok 1 selftests: iommu: iommufd # exit=1
not ok 26 selftests: kvm: vmx_preemption_timer_test # exit=254
not ok 1 selftests: landlock: fs_test # exit=1
not ok 1 selftests: mincore: mincore_selftest # exit=1
not ok 2 selftests: mqueue: mq_perf_tests # TIMEOUT 45 seconds
not ok 1 selftests: nci: nci_dev # exit=1
not ok 6 selftests: net: tls # exit=1
not ok 12 selftests: net: run_netsocktests # exit=1
not ok 28 selftests: net: udpgro_bench.sh # exit=255
not ok 29 selftests: net: udpgro.sh # exit=255
not ok 36 selftests: net: fcnal-test.sh # TIMEOUT 1500 seconds
not ok 37 selftests: net: l2tp.sh # exit=2
not ok 45 selftests: net: icmp_redirect.sh # exit=1
not ok 49 selftests: net: txtimestamp.sh # exit=1
not ok 54 selftests: net: vrf_route_leaking.sh # exit=1
not ok 58 selftests: net: udpgro_fwd.sh # exit=1
not ok 59 selftests: net: udpgro_frglist.sh # exit=255
not ok 60 selftests: net: veth.sh # exit=1
not ok 67 selftests: net: srv6_end_dt46_l3vpn_test.sh # exit=1
not ok 68 selftests: net: srv6_end_dt4_l3vpn_test.sh # exit=1
not ok 82 selftests: net: rps_default_mask.sh # exit=1
not ok 85 selftests: net: test_ingress_egress_chaining.sh # exit=1
not ok 1 selftests: net/hsr: hsr_ping.sh # TIMEOUT 45 seconds
not ok 3 selftests: net/mptcp: mptcp_join.sh # exit=1
not ok 3 selftests: netfilter: nft_nat.sh # exit=1
not ok 5 selftests: netfilter: conntrack_icmp_related.sh # exit=1
not ok 8 selftests: netfilter: nft_concat_range.sh # exit=1
not ok 14 selftests: netfilter: conntrack_tcp_unreplied.sh # exit=1
not ok 15 selftests: netfilter: conntrack_vrf.sh # exit=1
not ok 15 selftests: proc: read # exit=134
not ok 1 selftests: pstore: pstore_tests # exit=1
not ok 3 selftests: ptrace: vmaccess # exit=1
not ok 1 selftests: rlimits: rlimits-per-userns # exit=1
not ok 1 selftests: sgx: test_sgx # exit=1
not ok 2 selftests: splice: short_splice_read.sh # exit=3
not ok 1 selftests: tdx: tdx_guest_test # exit=1
not ok 3 selftests: mm: split_huge_page_test # exit=1
not ok 5 selftests: mm: mdwe_test # exit=1
[marvin@pc-mtodorov linux_torvalds]$

The environment is AlmaLinux 8.7 running 6.3-rc3 vanilla kernel with
MGLRU, KMEMLEAK and CONFIG_DEBUG_KOBJECT=y enabled.

Hw := LENOVO_MT_10TX_BU_Lenovo_FM_V530S-07ICB

In case you are interested to debug this, I am available for additional
diagnostics.

As 45 bug reports might overwhelm me due to the overhead of bug submission,
I will probably submit a bug or two at a time.

Best regards,
Mirsad


--
Mirsad Goran Todorovac
Sistem inženjer
Grafički fakultet | Akademija likovnih umjetnosti
Sveučilište u Zagrebu

System engineer
Faculty of Graphic Arts | Academy of Fine Arts
University of Zagreb, Republic of Croatia


Attachments:
tls-6.3-rc3-1.log (12.15 kB)

2023-03-21 02:59:13

by Jakub Kicinski

[permalink] [raw]
Subject: Re: BUG: selftests/net/tls: FAIL in sm4_ccm tests

On Mon, 20 Mar 2023 17:07:36 +0100 Mirsad Todorovac wrote:
> The environment is AlmaLinux 8.7 running 6.3-rc3 vanilla kernel with
> MGLRU, KMEMLEAK and CONFIG_DEBUG_KOBJECT=y enabled.

Do you have SM4 and CCM enabled in you kernel .config ?
It's not a popular cipher.
Make sure your config has all the options listed in
tools/testing/selftests/net/config

2023-03-21 19:57:23

by Mirsad Todorovac

[permalink] [raw]
Subject: Re: BUG: selftests/net/tls: FAIL in sm4_ccm tests

On 3/21/2023 3:59 AM, Jakub Kicinski wrote:
> On Mon, 20 Mar 2023 17:07:36 +0100 Mirsad Todorovac wrote:
>> The environment is AlmaLinux 8.7 running 6.3-rc3 vanilla kernel with
>> MGLRU, KMEMLEAK and CONFIG_DEBUG_KOBJECT=y enabled.
>
> Do you have SM4 and CCM enabled in you kernel .config ?
> It's not a popular cipher.
> Make sure your config has all the options listed in
> tools/testing/selftests/net/config

Done that. Thanks, now all tools/testing/selftest/net/tls tests passed:

# PASSED: 554 / 554 tests passed.
# Totals: pass:554 fail:0 xfail:0 xpass:0 skip:0 error:0

Should I then probably rebuild the kernel for the tests with
tools/testing/selftest/*/config merged?

Thanks,
Mirsad

--
Mirsad Todorovac
Sistem inženjer
Grafički fakultet | Akademija likovnih umjetnosti
Sveučilište u Zagrebu

System engineer
Faculty of Graphic Arts | Academy of Fine Arts
University of Zagreb, Republic of Croatia
tel. +385 (0)1 3711 451
mob. +385 91 57 88 355