2022-10-18 09:07:36

by Jiapeng Chong

Subject: [PATCH] dmaengine: ti: edma: Remove the unused function edma_and()

The function edma_and() is defined in the edma.c file, but not called
elsewhere, so remove this unused function.

drivers/dma/ti/edma.c:321:20: warning: unused function 'edma_and'.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2430
Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/dma/ti/edma.c | 8 --------
1 file changed, 8 deletions(-)

diff --git a/drivers/dma/ti/edma.c b/drivers/dma/ti/edma.c
index fa06d7e6d8e3..9ea91c640c32 100644
--- a/drivers/dma/ti/edma.c
+++ b/drivers/dma/ti/edma.c
@@ -318,14 +318,6 @@ static inline void edma_modify(struct edma_cc *ecc, int offset, unsigned and,
edma_write(ecc, offset, val);
}

-static inline void edma_and(struct edma_cc *ecc, int offset, unsigned and)
-{
- unsigned val = edma_read(ecc, offset);
-
- val &= and;
- edma_write(ecc, offset, val);
-}
-
static inline void edma_or(struct edma_cc *ecc, int offset, unsigned or)
{
unsigned val = edma_read(ecc, offset);
--
2.20.1.7.g153144c

2022-10-19 14:36:46

by Vinod Koul

Subject: Re: [PATCH] dmaengine: ti: edma: Remove the unused function edma_and()

On 18-10-22, 16:38, Jiapeng Chong wrote:
> The function edma_and() is defined in the edma.c file, but not called
> elsewhere, so remove this unused function.
>
> drivers/dma/ti/edma.c:321:20: warning: unused function 'edma_and'.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2430
> Reported-by: Abaci Robot <[email protected]>

Where is this report?

> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
> drivers/dma/ti/edma.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/dma/ti/edma.c b/drivers/dma/ti/edma.c
> index fa06d7e6d8e3..9ea91c640c32 100644
> --- a/drivers/dma/ti/edma.c
> +++ b/drivers/dma/ti/edma.c
> @@ -318,14 +318,6 @@ static inline void edma_modify(struct edma_cc *ecc, int offset, unsigned and,
> edma_write(ecc, offset, val);
> }
>
> -static inline void edma_and(struct edma_cc *ecc, int offset, unsigned and)
> -{
> - unsigned val = edma_read(ecc, offset);
> -
> - val &= and;
> - edma_write(ecc, offset, val);
> -}
> -
> static inline void edma_or(struct edma_cc *ecc, int offset, unsigned or)
> {
> unsigned val = edma_read(ecc, offset);
> --
> 2.20.1.7.g153144c

--
~Vinod

2022-10-26 17:31:10

by Péter Ujfalusi

Subject: Re: [PATCH] dmaengine: ti: edma: Remove the unused function edma_and()

On 18/10/2022 11:38, Jiapeng Chong wrote:
> The function edma_and() is defined in the edma.c file, but not called
> elsewhere, so remove this unused function.
>
> drivers/dma/ti/edma.c:321:20: warning: unused function 'edma_and'.

0f4c5b29e333 dmaengine: ti: edma: Remove some unused functions
dropped edma_param_and() but left the edma_and() behind...

Acked-by: Peter Ujfalusi <[email protected]>

>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2430
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
> drivers/dma/ti/edma.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/dma/ti/edma.c b/drivers/dma/ti/edma.c
> index fa06d7e6d8e3..9ea91c640c32 100644
> --- a/drivers/dma/ti/edma.c
> +++ b/drivers/dma/ti/edma.c
> @@ -318,14 +318,6 @@ static inline void edma_modify(struct edma_cc *ecc, int offset, unsigned and,
> edma_write(ecc, offset, val);
> }
>
> -static inline void edma_and(struct edma_cc *ecc, int offset, unsigned and)
> -{
> - unsigned val = edma_read(ecc, offset);
> -
> - val &= and;
> - edma_write(ecc, offset, val);
> -}
> -
> static inline void edma_or(struct edma_cc *ecc, int offset, unsigned or)
> {
> unsigned val = edma_read(ecc, offset);

--
Péter