2019-06-25 19:26:17

by Bartosz Golaszewski

Subject: [PATCH 02/12] backlight: gpio: use a helper variable for &pdev->dev

From: Bartosz Golaszewski <[email protected]>

Instead of dereferencing pdev each time, use a helper variable for
the associated device pointer.

Signed-off-by: Bartosz Golaszewski <[email protected]>
---
drivers/video/backlight/gpio_backlight.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backlight/gpio_backlight.c
index 654c19d3a81d..8adbc8d75097 100644
--- a/drivers/video/backlight/gpio_backlight.c
+++ b/drivers/video/backlight/gpio_backlight.c
@@ -83,15 +83,16 @@ static int gpio_backlight_probe(struct platform_device *pdev)
struct gpio_backlight_platform_data *pdata =
dev_get_platdata(&pdev->dev);
struct backlight_properties props;
+ struct device *dev = &pdev->dev;
struct backlight_device *bl;
struct gpio_backlight *gbl;
int ret;

- gbl = devm_kzalloc(&pdev->dev, sizeof(*gbl), GFP_KERNEL);
+ gbl = devm_kzalloc(dev, sizeof(*gbl), GFP_KERNEL);
if (gbl == NULL)
return -ENOMEM;

- gbl->dev = &pdev->dev;
+ gbl->dev = dev;

if (pdata) {
/*
@@ -108,7 +109,7 @@ static int gpio_backlight_probe(struct platform_device *pdev)
ret = devm_gpio_request_one(gbl->dev, pdata->gpio, flags,
pdata ? pdata->name : "backlight");
if (ret < 0) {
- dev_err(&pdev->dev, "unable to request GPIO\n");
+ dev_err(dev, "unable to request GPIO\n");
return ret;
}
gbl->gpiod = gpio_to_desc(pdata->gpio);
@@ -123,11 +124,10 @@ static int gpio_backlight_probe(struct platform_device *pdev)
memset(&props, 0, sizeof(props));
props.type = BACKLIGHT_RAW;
props.max_brightness = 1;
- bl = devm_backlight_device_register(&pdev->dev, dev_name(&pdev->dev),
- &pdev->dev, gbl, &gpio_backlight_ops,
- &props);
+ bl = devm_backlight_device_register(dev, dev_name(dev), dev, gbl,
+ &gpio_backlight_ops, &props);
if (IS_ERR(bl)) {
- dev_err(&pdev->dev, "failed to register backlight\n");
+ dev_err(dev, "failed to register backlight\n");
return PTR_ERR(bl);
}

--
2.21.0

2019-06-28 13:00:40

by Bartlomiej Zolnierkiewicz

Subject: Re: [PATCH 02/12] backlight: gpio: use a helper variable for &pdev->dev

On 6/25/19 6:34 PM, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <[email protected]>
>
> Instead of dereferencing pdev each time, use a helper variable for
> the associated device pointer.
>
> Signed-off-by: Bartosz Golaszewski <[email protected]>

Reviewed-by: Bartlomiej Zolnierkiewicz <[email protected]>

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

2019-07-02 09:06:27

by Daniel Thompson

Subject: Re: [PATCH 02/12] backlight: gpio: use a helper variable for &pdev->dev

On 25/06/2019 17:34, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <[email protected]>
>
> Instead of dereferencing pdev each time, use a helper variable for
> the associated device pointer.
>
> Signed-off-by: Bartosz Golaszewski <[email protected]>

No objections but I think this will need to be respun against
backlight-next (or v5.3).

> ---
> drivers/video/backlight/gpio_backlight.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backlight/gpio_backlight.c
> index 654c19d3a81d..8adbc8d75097 100644
> --- a/drivers/video/backlight/gpio_backlight.c
> +++ b/drivers/video/backlight/gpio_backlight.c
> @@ -83,15 +83,16 @@ static int gpio_backlight_probe(struct platform_device *pdev)
> struct gpio_backlight_platform_data *pdata =
> dev_get_platdata(&pdev->dev);

Why leave this one out?


Daniel.


> struct backlight_properties props;
> + struct device *dev = &pdev->dev;
> struct backlight_device *bl;
> struct gpio_backlight *gbl;
> int ret;
>
> - gbl = devm_kzalloc(&pdev->dev, sizeof(*gbl), GFP_KERNEL);
> + gbl = devm_kzalloc(dev, sizeof(*gbl), GFP_KERNEL);
> if (gbl == NULL)
> return -ENOMEM;
>
> - gbl->dev = &pdev->dev;
> + gbl->dev = dev;
>
> if (pdata) {
> /*
> @@ -108,7 +109,7 @@ static int gpio_backlight_probe(struct platform_device *pdev)
> ret = devm_gpio_request_one(gbl->dev, pdata->gpio, flags,
> pdata ? pdata->name : "backlight");
> if (ret < 0) {
> - dev_err(&pdev->dev, "unable to request GPIO\n");
> + dev_err(dev, "unable to request GPIO\n");
> return ret;
> }
> gbl->gpiod = gpio_to_desc(pdata->gpio);
> @@ -123,11 +124,10 @@ static int gpio_backlight_probe(struct platform_device *pdev)
> memset(&props, 0, sizeof(props));
> props.type = BACKLIGHT_RAW;
> props.max_brightness = 1;
> - bl = devm_backlight_device_register(&pdev->dev, dev_name(&pdev->dev),
> - &pdev->dev, gbl, &gpio_backlight_ops,
> - &props);
> + bl = devm_backlight_device_register(dev, dev_name(dev), dev, gbl,
> + &gpio_backlight_ops, &props);
> if (IS_ERR(bl)) {
> - dev_err(&pdev->dev, "failed to register backlight\n");
> + dev_err(dev, "failed to register backlight\n");
> return PTR_ERR(bl);
> }
>
>