2009-12-07 13:13:24

by Roel Kluin

Subject: [PATCH] IB/uverbs: PTR_ERR return of wrong pointer in ib_uverbs_get_context()

Return the PTR_ERR of the correct pointer.

Signed-off-by: Roel Kluin <[email protected]>
---
drivers/infiniband/core/uverbs_cmd.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

Unless this should be fixed otherwise?

diff --git a/drivers/infiniband/core/uverbs_cmd.c b/drivers/infiniband/core/uverbs_cmd.c
index 56feab6..112d397 100644
--- a/drivers/infiniband/core/uverbs_cmd.c
+++ b/drivers/infiniband/core/uverbs_cmd.c
@@ -285,7 +285,7 @@ ssize_t ib_uverbs_get_context(struct ib_uverbs_file *file,

ucontext = ibdev->alloc_ucontext(ibdev, &udata);
if (IS_ERR(ucontext)) {
- ret = PTR_ERR(file->ucontext);
+ ret = PTR_ERR(ucontext);
goto err;
}

2009-12-09 22:31:00

by Roland Dreier

Subject: Re: [PATCH] IB/uverbs: PTR_ERR return of wrong pointer in ib_uverbs_get_context()

Well spotted, applied thanks.