2009-10-09 17:42:56

by Roland Dreier

Subject: Staging: comedi: Add include of <linux/sched.h> to fix build

Commit a99bbaf5 ("headers: remove sched.h from poll.h") removed the
implicit include of <linux/sched.h> via <linux/poll.h>, and broke the
comedi build with errors like:

drivers/staging/comedi/drivers/serial2002.c:201: error: 'TASK_INTERRUPTIBLE' undeclared (first use in this function)

Explicitly include <linux/sched.h> to fix this.

Signed-off-by: Roland Dreier <[email protected]>
---
drivers/staging/comedi/drivers/serial2002.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/staging/comedi/drivers/serial2002.c b/drivers/staging/comedi/drivers/serial2002.c
index a219679..3b706ca 100644
--- a/drivers/staging/comedi/drivers/serial2002.c
+++ b/drivers/staging/comedi/drivers/serial2002.c
@@ -40,6 +40,7 @@ Status: in development
#include <asm/ioctls.h>
#include <linux/serial.h>
#include <linux/poll.h>
+#include <linux/sched.h>

/*
* Board descriptions for two imaginary boards. Describing the

2009-10-09 18:31:51

by Greg KH

Subject: Re: Staging: comedi: Add include of <linux/sched.h> to fix build

On Fri, Oct 09, 2009 at 10:42:09AM -0700, Roland Dreier wrote:
> Commit a99bbaf5 ("headers: remove sched.h from poll.h") removed the
> implicit include of <linux/sched.h> via <linux/poll.h>, and broke the
> comedi build with errors like:
>
> drivers/staging/comedi/drivers/serial2002.c:201: error: 'TASK_INTERRUPTIBLE' undeclared (first use in this function)
>
> Explicitly include <linux/sched.h> to fix this.
>
> Signed-off-by: Roland Dreier <[email protected]>

Heh, this is already in my tree, and will be sent to Linus today.

thanks,

greg k-h