2022-11-17 07:49:30

by Jiasheng Jiang

Subject: [PATCH] media: coda: Add check for kmalloc

As the kmalloc may return NULL pointer,
it should be better to check the return value
in order to avoid NULL poineter dereference,
same as the others.

Fixes: cb1d3a336371 ("[media] coda: add CODA7541 JPEG support")
Signed-off-by: Jiasheng Jiang <[email protected]>
---
drivers/media/platform/chips-media/coda-bit.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/media/platform/chips-media/coda-bit.c b/drivers/media/platform/chips-media/coda-bit.c
index 2736a902e3df..240bdbc64785 100644
--- a/drivers/media/platform/chips-media/coda-bit.c
+++ b/drivers/media/platform/chips-media/coda-bit.c
@@ -1084,10 +1084,16 @@ static int coda_start_encoding(struct coda_ctx *ctx)
}

if (dst_fourcc == V4L2_PIX_FMT_JPEG) {
- if (!ctx->params.jpeg_qmat_tab[0])
+ if (!ctx->params.jpeg_qmat_tab[0]) {
ctx->params.jpeg_qmat_tab[0] = kmalloc(64, GFP_KERNEL);
- if (!ctx->params.jpeg_qmat_tab[1])
+ if (!ctx->params.jpeg_qmat_tab[0])
+ return -ENOMEM;
+ }
+ if (!ctx->params.jpeg_qmat_tab[1]) {
ctx->params.jpeg_qmat_tab[1] = kmalloc(64, GFP_KERNEL);
+ if (!ctx->params.jpeg_qmat_tab[1])
+ return -ENOMEM;
+ }
coda_set_jpeg_compression_quality(ctx, ctx->params.jpeg_quality);
}

--
2.25.1

2022-12-16 17:44:54

by Philipp Zabel

Subject: Re: [PATCH] media: coda: Add check for kmalloc

On Do, 2022-11-17 at 15:02 +0800, Jiasheng Jiang wrote:
> As the kmalloc may return NULL pointer,
> it should be better to check the return value
> in order to avoid NULL poineter dereference,
> same as the others.
>
> Fixes: cb1d3a336371 ("[media] coda: add CODA7541 JPEG support")
> Signed-off-by: Jiasheng Jiang <[email protected]>

Reviewed-by: Philipp Zabel <[email protected]>

regards
Philipp