2024-01-15 20:12:39

by Trevor Gamblin

Subject: [PATCH 1/2] dt-bindings: pwm: Add bindings for AXI PWM generator

From: Drew Fustini <[email protected]>

Add bindings for Analog Devices AXI PWM generator.

Link: https://wiki.analog.com/resources/fpga/docs/axi_pwm_gen
Signed-off-by: Drew Fustini <[email protected]>
Co-developed-by: Trevor Gamblin <[email protected]>
Signed-off-by: Trevor Gamblin <[email protected]>
---
.../bindings/pwm/adi,axi-pwmgen.yaml | 48 +++++++++++++++++++
MAINTAINERS | 8 ++++
2 files changed, 56 insertions(+)
create mode 100644 Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml

diff --git a/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml b/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
new file mode 100644
index 000000000000..8f16b2e14154
--- /dev/null
+++ b/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
@@ -0,0 +1,48 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pwm/adi,axi-pwmgen.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices AXI PWM generator
+
+maintainers:
+ - Michael Hennerich <[email protected]>
+ - Nuno Sá <[email protected]>
+
+description:
+ The Analog Devices AXI PWM generator can generate PWM signals
+ with variable pulse width and period.
+
+ https://wiki.analog.com/resources/fpga/docs/axi_pwm_gen
+
+allOf:
+ - $ref: pwm.yaml#
+
+properties:
+ compatible:
+ const: adi,axi-pwmgen-1.00.a
+
+ reg:
+ maxItems: 1
+
+ "#pwm-cells":
+ const: 2
+
+ clocks:
+ maxItems: 1
+
+unevaluatedProperties: false
+
+required:
+ - reg
+ - clocks
+
+examples:
+ - |
+ pwm@44b00000 {
+ compatible = "adi,axi-pwmgen-1.00.a";
+ reg = <0x44b00000 0x1000>;
+ clocks = <&spi_clk>;
+ #pwm-cells = <2>;
+ };
diff --git a/MAINTAINERS b/MAINTAINERS
index c6c7b50e6ef6..7b0f3aec5381 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3415,6 +3415,14 @@ W: https://ez.analog.com/linux-software-drivers
F: Documentation/devicetree/bindings/hwmon/adi,axi-fan-control.yaml
F: drivers/hwmon/axi-fan-control.c

+AXI PWM GENERATOR
+M: Michael Hennerich <[email protected]>
+M: Nuno Sá <[email protected]>
+L: [email protected]
+S: Supported
+W: https://ez.analog.com/linux-software-drivers
+F: Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
+
AXXIA I2C CONTROLLER
M: Krzysztof Adamski <[email protected]>
L: [email protected]
--
2.43.0

2024-01-16 07:39:15

by Krzysztof Kozlowski

Subject: Re: [PATCH 1/2] dt-bindings: pwm: Add bindings for AXI PWM generator

On 15/01/2024 21:12, Trevor Gamblin wrote:
> From: Drew Fustini <[email protected]>
>
> Add bindings for Analog Devices AXI PWM generator.

If there is going to be new version, two things to fix:
A nit, subject: drop second/last, redundant "bindings for". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

>
> Link: https://wiki.analog.com/resources/fpga/docs/axi_pwm_gen
> Signed-off-by: Drew Fustini <[email protected]>
> Co-developed-by: Trevor Gamblin <[email protected]>
> Signed-off-by: Trevor Gamblin <[email protected]>
> ---
> .../bindings/pwm/adi,axi-pwmgen.yaml | 48 +++++++++++++++++++
> MAINTAINERS | 8 ++++
> 2 files changed, 56 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
>
> diff --git a/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml b/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
> new file mode 100644
> index 000000000000..8f16b2e14154
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pwm/adi,axi-pwmgen.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices AXI PWM generator
> +
> +maintainers:
> + - Michael Hennerich <[email protected]>
> + - Nuno Sá <[email protected]>
> +
> +description:
> + The Analog Devices AXI PWM generator can generate PWM signals
> + with variable pulse width and period.
> +
> + https://wiki.analog.com/resources/fpga/docs/axi_pwm_gen
> +
> +allOf:
> + - $ref: pwm.yaml#
> +
> +properties:
> + compatible:
> + const: adi,axi-pwmgen-1.00.a
> +
> + reg:
> + maxItems: 1
> +
> + "#pwm-cells":
> + const: 2
> +
> + clocks:
> + maxItems: 1
> +
> +unevaluatedProperties: false

This goes after "required:"

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof