2022-11-08 15:08:14

by Nicolas Ferre

Subject: Re: [PATCHv1 3/8] ARM: dts: at91: sam9x60: Add flexcom definitions

On 31/10/2022 at 04:36, Durai Manickam KR wrote:
> Add the flexcom definitions to the SoC specifc DTSI file.
>
> Signed-off-by: Durai Manickam KR <[email protected]>
> Signed-off-by: Hari Prasath <[email protected]>
> Signed-off-by: Manikandan M <[email protected]>
> ---
> arch/arm/boot/dts/sam9x60.dtsi | 52 ++++++++++++++++++++++++++++++++--
> 1 file changed, 50 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sam9x60.dtsi b/arch/arm/boot/dts/sam9x60.dtsi
> index ef07d281a3db..fd4f5d43f7bb 100644
> --- a/arch/arm/boot/dts/sam9x60.dtsi
> +++ b/arch/arm/boot/dts/sam9x60.dtsi

[..]

> @@ -180,6 +190,26 @@ flx5: flexcom@f0004000 {
> #size-cells = <1>;
> ranges = <0x0 0xf0004000 0x800>;
> status = "disabled";
> +
> + uart5: serial@200 {
> + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
> + reg = <0x200 0x200>;
> + interrupts = <14 IRQ_TYPE_LEVEL_HIGH 7>;
> + dmas = <&dma0
> + (AT91_XDMAC_DT_MEM_IF(0) |
> + AT91_XDMAC_DT_PER_IF(1) |
> + AT91_XDMAC_DT_PERID(10))>,
> + <&dma0
> + (AT91_XDMAC_DT_MEM_IF(0) |
> + AT91_XDMAC_DT_PER_IF(1) |
> + AT91_XDMAC_DT_PERID(11))>;
> + dma-names = "tx", "rx";
> + clocks = <&pmc PMC_TYPE_PERIPHERAL 14>;
> + clock-names = "usart";
> + atmel,use-dma-rx;
> + atmel,use-dma-tx;

Isn't "atmel,fifo-size = <16>;" missing in this added definition?

> + status = "disabled";
> + };
> };
>
> dma0: dma-controller@f0008000 {

[..]

Regards,
Nicolas

--
Nicolas Ferre

2022-11-15 06:10:16

by Durai Manickam KR

Subject: Re: [PATCHv1 3/8] ARM: dts: at91: sam9x60: Add flexcom definitions

On 08/11/22 19:07, Nicolas Ferre wrote:
> On 31/10/2022 at 04:36, Durai Manickam KR wrote:
>> Add the flexcom definitions to the SoC specifc DTSI file.
>>
>> Signed-off-by: Durai Manickam KR <[email protected]>
>> Signed-off-by: Hari Prasath <[email protected]>
>> Signed-off-by: Manikandan M <[email protected]>
>> ---
>>   arch/arm/boot/dts/sam9x60.dtsi | 52 ++++++++++++++++++++++++++++++++--
>>   1 file changed, 50 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/sam9x60.dtsi
>> b/arch/arm/boot/dts/sam9x60.dtsi
>> index ef07d281a3db..fd4f5d43f7bb 100644
>> --- a/arch/arm/boot/dts/sam9x60.dtsi
>> +++ b/arch/arm/boot/dts/sam9x60.dtsi
>
> [..]
>
>> @@ -180,6 +190,26 @@ flx5: flexcom@f0004000 {
>>                   #size-cells = <1>;
>>                   ranges = <0x0 0xf0004000 0x800>;
>>                   status = "disabled";
>> +
>> +                uart5: serial@200 {
>> +                    compatible = "microchip,sam9x60-usart",
>> "atmel,at91sam9260-usart";
>> +                    reg = <0x200 0x200>;
>> +                    interrupts = <14 IRQ_TYPE_LEVEL_HIGH 7>;
>> +                    dmas = <&dma0
>> +                        (AT91_XDMAC_DT_MEM_IF(0) |
>> +                         AT91_XDMAC_DT_PER_IF(1) |
>> +                         AT91_XDMAC_DT_PERID(10))>,
>> +                        <&dma0
>> +                        (AT91_XDMAC_DT_MEM_IF(0) |
>> +                         AT91_XDMAC_DT_PER_IF(1) |
>> +                         AT91_XDMAC_DT_PERID(11))>;
>> +                    dma-names = "tx", "rx";
>> +                    clocks = <&pmc PMC_TYPE_PERIPHERAL 14>;
>> +                    clock-names = "usart";
>> +                    atmel,use-dma-rx;
>> +                    atmel,use-dma-tx;
>
> Isn't "atmel,fifo-size = <16>;" missing in this added definition?
> Hi Nicolas,
Yes you are right. It is added as separate patch in the same patch series.
>> +                    status = "disabled";
>> +                };
>>               };
>>                 dma0: dma-controller@f0008000 {
>
> [..]
>
> Regards,
>   Nicolas
>