2022-10-19 07:39:55

by Colin Ian King

[permalink] [raw]
Subject: [PATCH][next][V2] ASoC: codecs: jz4725b: Fix spelling mistake "Sourc" -> "Source", "Routee" -> "Route"

There are two spelling mistakes in codec routing description. Fix it.

Signed-off-by: Colin Ian King <[email protected]>
---
V2: Fix "Routee" -> "Route" too
---
sound/soc/codecs/jz4725b.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/jz4725b.c b/sound/soc/codecs/jz4725b.c
index 685ba1d3a644..64b14b1c74b9 100644
--- a/sound/soc/codecs/jz4725b.c
+++ b/sound/soc/codecs/jz4725b.c
@@ -359,7 +359,7 @@ static const struct snd_soc_dapm_route jz4725b_codec_dapm_routes[] = {

{"Mixer to ADC", NULL, "Mixer"},
{"ADC Source Capture Route", "Mixer", "Mixer to ADC"},
- {"ADC Sourc Capture Routee", "Line In", "Line In"},
+ {"ADC Source Capture Route", "Line In", "Line In"},
{"ADC Source Capture Route", "Mic 1", "Mic 1"},
{"ADC Source Capture Route", "Mic 2", "Mic 2"},
{"ADC", NULL, "ADC Source Capture Route"},
--
2.37.3


2022-10-19 08:15:22

by Philippe Mathieu-Daudé

[permalink] [raw]
Subject: Re: [PATCH][next][V2] ASoC: codecs: jz4725b: Fix spelling mistake "Sourc" -> "Source", "Routee" -> "Route"

On 19/10/22 09:16, Colin Ian King wrote:
> There are two spelling mistakes in codec routing description. Fix it.
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> V2: Fix "Routee" -> "Route" too
> ---
> sound/soc/codecs/jz4725b.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <[email protected]>


2022-10-19 12:56:11

by Colin Ian King

[permalink] [raw]
Subject: Re: [PATCH][next][V2] ASoC: codecs: jz4725b: Fix spelling mistake "Sourc" -> "Source", "Routee" -> "Route"

On 19/10/2022 13:19, Paul Cercueil wrote:
> Hi Mark,
>
> Le mer., oct. 19 2022 at 13:10:49 +0100, Mark Brown <[email protected]>
> a écrit :
>> On Wed, Oct 19, 2022 at 08:16:39AM +0100, Colin Ian King wrote:
>>>  There are two spelling mistakes in codec routing description. Fix it.
>>
>> Bit disappionting that people didn't notice the errors during boot
>> there...
>
> Well that's on you. You merged the patchset before anybody could review.
>
> -Paul
>
>
Fortunately I spell check linux-next daily to catch these typos.

Colin

2022-10-19 12:57:55

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH][next][V2] ASoC: codecs: jz4725b: Fix spelling mistake "Sourc" -> "Source", "Routee" -> "Route"

On Wed, Oct 19, 2022 at 08:16:39AM +0100, Colin Ian King wrote:
> There are two spelling mistakes in codec routing description. Fix it.

Bit disappionting that people didn't notice the errors during boot
there...


Attachments:
(No filename) (218.00 B)
signature.asc (499.00 B)
Download all attachments

2022-10-19 13:20:19

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH][next][V2] ASoC: codecs: jz4725b: Fix spelling mistake "Sourc" -> "Source", "Routee" -> "Route"

On Wed, Oct 19, 2022 at 01:19:40PM +0100, Paul Cercueil wrote:
> Le mer., oct. 19 2022 at 13:10:49 +0100, Mark Brown <[email protected]> a
> > On Wed, Oct 19, 2022 at 08:16:39AM +0100, Colin Ian King wrote:

> > > There are two spelling mistakes in codec routing description. Fix
> > > it.

> > Bit disappionting that people didn't notice the errors during boot
> > there...

> Well that's on you. You merged the patchset before anybody could review.

That includes whoever wrote the code in the first place, and I do note
that I applied version 3 of the series.


Attachments:
(No filename) (579.00 B)
signature.asc (499.00 B)
Download all attachments

2022-10-19 13:56:59

by Paul Cercueil

[permalink] [raw]
Subject: Re: [PATCH][next][V2] ASoC: codecs: jz4725b: Fix spelling mistake "Sourc" -> "Source", "Routee" -> "Route"

Hi Mark,

Le mer., oct. 19 2022 at 13:10:49 +0100, Mark Brown
<[email protected]> a ?crit :
> On Wed, Oct 19, 2022 at 08:16:39AM +0100, Colin Ian King wrote:
>> There are two spelling mistakes in codec routing description. Fix
>> it.
>
> Bit disappionting that people didn't notice the errors during boot
> there...

Well that's on you. You merged the patchset before anybody could review.

-Paul


2022-10-19 14:37:29

by Paul Cercueil

[permalink] [raw]
Subject: Re: [PATCH][next][V2] ASoC: codecs: jz4725b: Fix spelling mistake "Sourc" -> "Source", "Routee" -> "Route"

Hi Colin,

Le mer., oct. 19 2022 at 08:16:39 +0100, Colin Ian King
<[email protected]> a ?crit :
> There are two spelling mistakes in codec routing description. Fix it.
>
> Signed-off-by: Colin Ian King <[email protected]>

Acked-by: Paul Cercueil <[email protected]>

Cheers,
-Paul

> ---
> V2: Fix "Routee" -> "Route" too
> ---
> sound/soc/codecs/jz4725b.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/jz4725b.c b/sound/soc/codecs/jz4725b.c
> index 685ba1d3a644..64b14b1c74b9 100644
> --- a/sound/soc/codecs/jz4725b.c
> +++ b/sound/soc/codecs/jz4725b.c
> @@ -359,7 +359,7 @@ static const struct snd_soc_dapm_route
> jz4725b_codec_dapm_routes[] = {
>
> {"Mixer to ADC", NULL, "Mixer"},
> {"ADC Source Capture Route", "Mixer", "Mixer to ADC"},
> - {"ADC Sourc Capture Routee", "Line In", "Line In"},
> + {"ADC Source Capture Route", "Line In", "Line In"},
> {"ADC Source Capture Route", "Mic 1", "Mic 1"},
> {"ADC Source Capture Route", "Mic 2", "Mic 2"},
> {"ADC", NULL, "ADC Source Capture Route"},
> --
> 2.37.3
>


2022-10-19 17:08:02

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH][next][V2] ASoC: codecs: jz4725b: Fix spelling mistake "Sourc" -> "Source", "Routee" -> "Route"

On Wed, 19 Oct 2022 08:16:39 +0100, Colin Ian King wrote:
> There are two spelling mistakes in codec routing description. Fix it.
>
>

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: codecs: jz4725b: Fix spelling mistake "Sourc" -> "Source", "Routee" -> "Route"
commit: df496157a5afa1b6d1f4c46ad6549c2c346d1e59

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark