2017-04-12 08:33:43

by Dan Carpenter

Subject: [PATCH] c2port: checking for NULL instead of IS_ERR()

c2port_device_register() never returns NULL, it uses error pointers.

Fixes: 65131cd52b9e ("c2port: add c2port support for Eurotech Duramar 2150")
Signed-off-by: Dan Carpenter <[email protected]>

diff --git a/drivers/misc/c2port/c2port-duramar2150.c b/drivers/misc/c2port/c2port-duramar2150.c
index 5484301d57d9..3dc61ea7dc64 100644
--- a/drivers/misc/c2port/c2port-duramar2150.c
+++ b/drivers/misc/c2port/c2port-duramar2150.c
@@ -129,8 +129,8 @@ static int __init duramar2150_c2port_init(void)

duramar2150_c2port_dev = c2port_device_register("uc",
&duramar2150_c2port_ops, NULL);
- if (!duramar2150_c2port_dev) {
- ret = -ENODEV;
+ if (IS_ERR(duramar2150_c2port_dev)) {
+ ret = PTR_ERR(duramar2150_c2port_dev);
goto free_region;
}

2017-04-12 09:42:18

by Rodolfo Giometti

Subject: Re: [PATCH] c2port: checking for NULL instead of IS_ERR()

On 04/12/17 10:33, Dan Carpenter wrote:
> c2port_device_register() never returns NULL, it uses error pointers.
>
> Fixes: 65131cd52b9e ("c2port: add c2port support for Eurotech Duramar 2150")
> Signed-off-by: Dan Carpenter <[email protected]>

Acked-by: Rodolfo Giometti <[email protected]>

> diff --git a/drivers/misc/c2port/c2port-duramar2150.c b/drivers/misc/c2port/c2port-duramar2150.c
> index 5484301d57d9..3dc61ea7dc64 100644
> --- a/drivers/misc/c2port/c2port-duramar2150.c
> +++ b/drivers/misc/c2port/c2port-duramar2150.c
> @@ -129,8 +129,8 @@ static int __init duramar2150_c2port_init(void)
>
> duramar2150_c2port_dev = c2port_device_register("uc",
> &duramar2150_c2port_ops, NULL);
> - if (!duramar2150_c2port_dev) {
> - ret = -ENODEV;
> + if (IS_ERR(duramar2150_c2port_dev)) {
> + ret = PTR_ERR(duramar2150_c2port_dev);
> goto free_region;
> }
>
>

--

HCE Engineering e-mail: [email protected]
GNU/Linux Solutions [email protected]
Linux Device Driver [email protected]
Embedded Systems phone: +39 349 2432127
UNIX programming skype: rodolfo.giometti
Cosino Project - the quick prototyping embedded system - http://www.cosino.io
Freelance ICT Italia - Consulente ICT Italia - http://www.consulenti-ict.it